History

avfilter/avf_ahistogram: refactor frame fill data code

Paul B Mahol committed 3 years ago

Commit 1636fb41 parent c5508f61 file · +36 −16Browse files

Showing the changes to libavfilter (1 of 1 file). Show all

Unified · Split

libavfilter/avf_ahistogram.c+36−16
@@ -207,6 +207,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 206 unmodified lines
207207 AVFilterContext *ctx = inlink->dst;
208208 AVFilterLink *outlink = ctx->outputs[0];
209209 AudioHistogramContext *s = ctx->priv;
210+ const int nb_samples = in->nb_samples;
210211 const int H = s->histogram_h;
211212 const int w = s->w;
212213 int c, y, n, p, bin, ret;
@@ -260,7 +261,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 47 unmodified lines
260261 const float *src = (const float *)in->extended_data[c];
261262 uint64_t *achistogram = &s->achistogram[(s->dmode == SINGLE ? 0: c) * w];
262263
263− for (n = 0; n < in->nb_samples; n++) {
264+ for (n = 0; n < nb_samples; n++) {
264265 bin = s->get_bin(src[n], w);
265266
266267 achistogram[bin]++;
@@ -270,7 +271,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 3 unmodified lines
270271 uint64_t *shistogram = &s->shistogram[(s->dmode == SINGLE ? 0: c) * w];
271272 const float *src2 = (const float *)s->in[s->first]->extended_data[c];
272273
273− for (n = 0; n < in->nb_samples; n++) {
274+ for (n = 0; n < nb_samples; n++) {
274275 bin = s->get_bin(src2[n], w);
275276
276277 shistogram[bin]++;
@@ -283,7 +284,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 6 unmodified lines
283284 const float *src = (const float *)in->extended_data[c];
284285 uint64_t *achistogram = &s->achistogram[(s->dmode == SINGLE ? 0: c) * w];
285286
286− for (n = 0; n < in->nb_samples; n++) {
287+ for (n = 0; n < nb_samples; n++) {
287288 bin = s->get_bin(src[n], w);
288289
289290 achistogram[bin]++;
@@ -293,7 +294,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 3 unmodified lines
293294 uint64_t *shistogram = &s->shistogram[(s->dmode == SINGLE ? 0: c) * w];
294295 const float *src2 = (const float *)s->in[s->first]->extended_data[c];
295296
296− for (n = 0; n < in->nb_samples; n++) {
297+ for (n = 0; n < nb_samples; n++) {
297298 bin = s->get_bin(src2[n], w);
298299
299300 shistogram[bin]++;
@@ -357,10 +358,15 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 57 unmodified lines
357358 h = aa * (H - 1);
358359
359360 if (s->dmode == SINGLE) {
360−
361− for (y = H - h; y < H; y++) {
362− s->out->data[0][y * s->out->linesize[0] + n] = 255;
363− s->out->data[3][y * s->out->linesize[0] + n] = 255;
361+ int start = H - h, end = H;
362+ const int linesizey = s->out->linesize[0];
363+ const int linesizea = s->out->linesize[3];
364+ uint8_t *dsty = s->out->data[0] + start * linesizey;
365+ uint8_t *dsta = s->out->data[3] + start * linesizea;
366+
367+ for (y = start; y < end; y++, dsty += linesizey, dsta += linesizea) {
368+ dsty[n] = 255;
369+ dsta[n] = 255;
364370 }
365371
366372 if (s->h - H > 0) {
@@ -372,18 +378,32 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) · 5 unmodified lines
372378 s->out->data[3][s->ypos * s->out->linesize[3] + n] = 255;
373379 }
374380 } else if (s->dmode == SEPARATE) {
381+ int start = H - h, end = H;
375382 float *out = &s->combine_buffer[3 * n];
383+ const int linesizey = s->out->linesize[0];
384+ const int linesizeu = s->out->linesize[1];
385+ const int linesizev = s->out->linesize[2];
386+ const int linesizea = s->out->linesize[3];
387+ uint8_t *dsty = s->out->data[0] + start * linesizey;
388+ uint8_t *dstu = s->out->data[1] + start * linesizeu;
389+ uint8_t *dstv = s->out->data[2] + start * linesizev;
390+ uint8_t *dsta = s->out->data[3] + start * linesizea;
376391 int old;
377392
378− old = s->out->data[0][(H - h) * s->out->linesize[0] + n];
379− for (y = H - h; y < H; y++) {
380− if (s->out->data[0][y * s->out->linesize[0] + n] != old)
393+ old = dsty[n];
394+ for (y = start; y < end; y++) {
395+ if (dsty[n] != old)
381396 break;
382− old = s->out->data[0][y * s->out->linesize[0] + n];
383− s->out->data[0][y * s->out->linesize[0] + n] = av_clip_uint8(yf);
384− s->out->data[1][y * s->out->linesize[1] + n] = av_clip_uint8(128.f+uf);
385− s->out->data[2][y * s->out->linesize[2] + n] = av_clip_uint8(128.f+vf);
386− s->out->data[3][y * s->out->linesize[3] + n] = 255;
397+ old = dsty[n];
398+ dsty[n] = av_clip_uint8(yf);
399+ dstu[n] = av_clip_uint8(128.f+uf);
400+ dstv[n] = av_clip_uint8(128.f+vf);
401+ dsta[n] = 255;
402+
403+ dsty += linesizey;
404+ dstu += linesizeu;
405+ dstv += linesizev;
406+ dsta += linesizea;
387407 }
388408
389409 out[0] += aa * yf;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t