History

avcodec/ffv1enc: avoid slices larger than 360x288 if no value is specified

This improves speed by providing more independent things for more CPUs

Michael Niedermayer committed 1 year ago

Commit 175cd4c1 parent 1b04fb32 files · +13 −9Browse files

Unified · Split

2 files
  1. libavcodec/ffv1enc.c +5 −1
  2. tests/ref/fate/matroska-mastering-display-metadata +8 −8
libavcodec/ffv1enc.c+5−1
@@ -581,7 +581,11 @@ int ff_ffv1_encode_determine_slices(AVCodecContext *avctx) · 580 unmodified lines
581581 if ( ff_need_new_slices(avctx->width , s->num_h_slices, s->chroma_h_shift)
582582 ||ff_need_new_slices(avctx->height, s->num_v_slices, s->chroma_v_shift))
583583 continue;
584− if (avctx->slices == s->num_h_slices * s->num_v_slices && avctx->slices <= MAX_SLICES || !avctx->slices)
584+ if (avctx->slices == s->num_h_slices * s->num_v_slices && avctx->slices <= MAX_SLICES)
585+ return 0;
586+ if (maxw*maxh > 360*288)
587+ continue;
588+ if (!avctx->slices)
585589 return 0;
586590 }
587591 }
tests/ref/fate/matroska-mastering-display-metadata+8−8
@@ -1,7 +1,7 @@
1−ad5e3c4e338599c81ef7d0f9ae25f871 *tests/data/fate/matroska-mastering-display-metadata.matroska
2−1669589 tests/data/fate/matroska-mastering-display-metadata.matroska
1+c1e5e2ecf433cf05af8556debc7d4d0b *tests/data/fate/matroska-mastering-display-metadata.matroska
2+1669773 tests/data/fate/matroska-mastering-display-metadata.matroska
33 #extradata 0: 4, 0x040901a3
4−#extradata 3: 200, 0x506463a8
4+#extradata 3: 202, 0xfce96279
55 #tb 0: 1/1000
66 #media_type 0: video
77 #codec_id 0: prores
@@ -24,23 +24,23 @@ ad5e3c4e338599c81ef7d0f9ae25f871 *tests/data/fate/matroska-mastering-display-met · 16 unmodified lines
2424 #sar 3: 1/1
2525 0, 0, 0, 16, 57008, 0x43416399
2626 1, 0, 0, 16, 2403, 0xaa818522
27−3, 0, 0, 16, 274117, 0xc439610f
27+3, 0, 0, 16, 274884, 0x775840e5
2828 0, 17, 17, 16, 57248, 0xa06cd7b5
2929 1, 17, 17, 16, 2403, 0xe1a991e5
3030 2, 17, 17, 16, 1602, 0x5d868171
31−3, 17, 17, 16, 273691, 0x5a3b88a5, F=0x0
31+3, 17, 17, 16, 273716, 0xa41fc5e3, F=0x0
3232 0, 33, 33, 16, 57200, 0x5623da10
3333 1, 33, 33, 16, 2400, 0x6650907f
3434 2, 33, 33, 16, 1600, 0xa90f0044
35−3, 33, 33, 16, 272987, 0x48c443e7, F=0x0
35+3, 33, 33, 16, 272838, 0x3c308d03, F=0x0
3636 0, 50, 50, 16, 57152, 0x52d89d3f
3737 1, 50, 50, 16, 2403, 0x43398a08
3838 2, 50, 50, 16, 1602, 0x3a350084
39−3, 50, 50, 16, 271465, 0x251b9cbe, F=0x0
39+3, 50, 50, 16, 271251, 0xe802cc77, F=0x0
4040 0, 67, 67, 16, 56960, 0x431d5189
4141 1, 67, 67, 16, 2403, 0x61cd96cb
4242 2, 67, 67, 16, 1602, 0xd74800c6
43−3, 67, 67, 16, 270800, 0x8fb2e217, F=0x0
43+3, 67, 67, 16, 270553, 0x36d83705, F=0x0
4444 [STREAM]
4545 index=0
4646 codec_name=prores

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t