The current logic only fixes it when the user does not explicitly specify the chroma location. However, this does not make a lot of sense. Since there is no way to specify this property per-field, it effectively *prevents* the user from being able to correctly scale interlaced frames with top-aligned chroma. It makes more sense to consider the user setting in the progressive case only, and automatically adapt it to the correct interlaced field positions, following the details of the MPEG specification.
Showing the changes to libavfilter (1 of 1 file). Show all
Unified · Split
| @@ -713,12 +713,18 @@ static int config_props(AVFilterLink *outlink) · 712 unmodified lines | ||
| 713 | 713 | * chroma positions. MPEG chroma positions are used by convention. |
| 714 | 714 | * Note that this works for both MPEG-1/JPEG and MPEG-2/4 chroma |
| 715 | 715 | * locations, since they share a vertical alignment */ |
| 716 | − if (desc->log2_chroma_h == 1 && scale->in_v_chr_pos == -513) { | |
| 717 | − in_v_chr_pos = (i == 0) ? 128 : (i == 1) ? 64 : 192; | |
| 716 | + if (desc->log2_chroma_h == 1) { | |
| 717 | + if (in_v_chr_pos == -513) | |
| 718 | + in_v_chr_pos = 128; /* explicitly default missing info */ | |
| 719 | + in_v_chr_pos += 256 * (i == 2); /* offset by one luma row for odd rows */ | |
| 720 | + in_v_chr_pos >>= i > 0; /* double luma row distance */ | |
| 718 | 721 | } |
| 719 | 722 | |
| 720 | − if (outdesc->log2_chroma_h == 1 && scale->out_v_chr_pos == -513) { | |
| 721 | − out_v_chr_pos = (i == 0) ? 128 : (i == 1) ? 64 : 192; | |
| 723 | + if (outdesc->log2_chroma_h == 1) { | |
| 724 | + if (out_v_chr_pos == -513) | |
| 725 | + out_v_chr_pos = 128; | |
| 726 | + out_v_chr_pos += 256 * (i == 2); | |
| 727 | + out_v_chr_pos >>= i > 0; | |
| 722 | 728 | } |
| 723 | 729 | |
| 724 | 730 | av_opt_set_int(s, "src_h_chr_pos", scale->in_h_chr_pos, 0); |