History

avcodec/mpeg4videodec: Fix runtime error: signed integer overflow: 53098 * 40448 cannot be represented in type 'int'

Fixes: 2106/clusterfuzz-testcase-minimized-6136503639998464

Michael Niedermayer committed 9 years ago

Commit 18bca251 parent c4360551 file · +2 −2Browse files

Unified · Split

libavcodec/mpeg4videodec.c+2−2
@@ -2340,7 +2340,7 @@ static int decode_vop_header(Mpeg4DecContext *ctx, GetBitContext *gb) · 2339 unmodified lines
23402340 if (s->pict_type != AV_PICTURE_TYPE_B) {
23412341 s->last_time_base = s->time_base;
23422342 s->time_base += time_incr;
2343− s->time = s->time_base * s->avctx->framerate.num + time_increment;
2343+ s->time = s->time_base * (int64_t)s->avctx->framerate.num + time_increment;
23442344 if (s->workaround_bugs & FF_BUG_UMP4) {
23452345 if (s->time < s->last_non_b_time) {
23462346 /* header is not mpeg-4-compatible, broken encoder,
@@ -2352,7 +2352,7 @@ static int decode_vop_header(Mpeg4DecContext *ctx, GetBitContext *gb) · 5 unmodified lines
23522352 s->pp_time = s->time - s->last_non_b_time;
23532353 s->last_non_b_time = s->time;
23542354 } else {
2355− s->time = (s->last_time_base + time_incr) * s->avctx->framerate.num + time_increment;
2355+ s->time = (s->last_time_base + time_incr) * (int64_t)s->avctx->framerate.num + time_increment;
23562356 s->pb_time = s->pp_time - (s->last_non_b_time - s->time);
23572357 if (s->pp_time <= s->pb_time ||
23582358 s->pp_time <= s->pp_time - s->pb_time ||

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t