History

lavc/x86/videodsp: Drop MMX usage

Remove the MMX versions of these functions and modify the SSE implementations to avoid using MMX registers.

Frank Plowman committed 1 year ago

Commit 1e3dc701 parent 4de67e82 files · +59 −90Browse files

Showing the changes to libavcodec (2 of 2 files). Show all

Unified · Split

2 files
  1. libavcodec/x86/videodsp.asm +15 −46
  2. libavcodec/x86/videodsp_init.c +44 −44
libavcodec/x86/videodsp.asm+15−46
@@ -123,54 +123,43 @@ hvar_fn · 122 unmodified lines
123123 ; - if (%2 & 8) fills 8 bytes into xmm$next
124124 ; - if (%2 & 4) fills 4 bytes into xmm$next
125125 ; - if (%2 & 3) fills 1, 2 or 4 bytes in eax
126−; on mmx, - fills mm0-7 for consecutive sets of 8 pixels
127−; - if (%2 & 4) fills 4 bytes into mm$next
128−; - if (%2 & 3) fills 1, 2 or 4 bytes in eax
129126 ; writing data out is in the same way
130127 %macro READ_NUM_BYTES 2
131128 %assign %%off 0 ; offset in source buffer
132−%assign %%mmx_idx 0 ; mmx register index
133129 %assign %%xmm_idx 0 ; xmm register index
134130
135131 %rep %2/mmsize
136−%if mmsize == 16
137132 movu xmm %+ %%xmm_idx, [srcq+%%off]
138133 %assign %%xmm_idx %%xmm_idx+1
139−%else ; mmx
140− movu mm %+ %%mmx_idx, [srcq+%%off]
141−%assign %%mmx_idx %%mmx_idx+1
142−%endif
143134 %assign %%off %%off+mmsize
144135 %endrep ; %2/mmsize
145136
146−%if mmsize == 16
147137 %if (%2-%%off) >= 8
148138 %if %2 > 16 && (%2-%%off) > 8
149139 movu xmm %+ %%xmm_idx, [srcq+%2-16]
150140 %assign %%xmm_idx %%xmm_idx+1
151141 %assign %%off %2
152142 %else
153− movq mm %+ %%mmx_idx, [srcq+%%off]
154−%assign %%mmx_idx %%mmx_idx+1
143+ movq xmm %+ %%xmm_idx, [srcq+%%off]
144+%assign %%xmm_idx %%xmm_idx+1
155145 %assign %%off %%off+8
156146 %endif
157147 %endif ; (%2-%%off) >= 8
158−%endif
159148
160149 %if (%2-%%off) >= 4
161150 %if %2 > 8 && (%2-%%off) > 4
162− movq mm %+ %%mmx_idx, [srcq+%2-8]
151+ movq xmm %+ %%xmm_idx, [srcq+%2-8]
163152 %assign %%off %2
164153 %else
165− movd mm %+ %%mmx_idx, [srcq+%%off]
154+ movd xmm %+ %%xmm_idx, [srcq+%%off]
166155 %assign %%off %%off+4
167156 %endif
168−%assign %%mmx_idx %%mmx_idx+1
157+%assign %%xmm_idx %%xmm_idx+1
169158 %endif ; (%2-%%off) >= 4
170159
171160 %if (%2-%%off) >= 1
172161 %if %2 >= 4
173− movd mm %+ %%mmx_idx, [srcq+%2-4]
162+ movd xmm %+ %%xmm_idx, [srcq+%2-4]
174163 %elif (%2-%%off) == 1
175164 mov valb, [srcq+%2-1]
176165 %elif (%2-%%off) == 2
@@ -185,48 +174,40 @@ hvar_fn · 8 unmodified lines
185174
186175 %macro WRITE_NUM_BYTES 2
187176 %assign %%off 0 ; offset in destination buffer
188−%assign %%mmx_idx 0 ; mmx register index
189177 %assign %%xmm_idx 0 ; xmm register index
190178
191179 %rep %2/mmsize
192−%if mmsize == 16
193180 movu [dstq+%%off], xmm %+ %%xmm_idx
194181 %assign %%xmm_idx %%xmm_idx+1
195−%else ; mmx
196− movu [dstq+%%off], mm %+ %%mmx_idx
197−%assign %%mmx_idx %%mmx_idx+1
198−%endif
199182 %assign %%off %%off+mmsize
200183 %endrep ; %2/mmsize
201184
202−%if mmsize == 16
203185 %if (%2-%%off) >= 8
204186 %if %2 > 16 && (%2-%%off) > 8
205187 movu [dstq+%2-16], xmm %+ %%xmm_idx
206188 %assign %%xmm_idx %%xmm_idx+1
207189 %assign %%off %2
208190 %else
209− movq [dstq+%%off], mm %+ %%mmx_idx
210−%assign %%mmx_idx %%mmx_idx+1
191+ movq [dstq+%%off], xmm %+ %%xmm_idx
192+%assign %%xmm_idx %%xmm_idx+1
211193 %assign %%off %%off+8
212194 %endif
213195 %endif ; (%2-%%off) >= 8
214−%endif
215196
216197 %if (%2-%%off) >= 4
217198 %if %2 > 8 && (%2-%%off) > 4
218− movq [dstq+%2-8], mm %+ %%mmx_idx
199+ movq [dstq+%2-8], xmm %+ %%xmm_idx
219200 %assign %%off %2
220201 %else
221− movd [dstq+%%off], mm %+ %%mmx_idx
202+ movd [dstq+%%off], xmm %+ %%xmm_idx
222203 %assign %%off %%off+4
223204 %endif
224−%assign %%mmx_idx %%mmx_idx+1
205+%assign %%xmm_idx %%xmm_idx+1
225206 %endif ; (%2-%%off) >= 4
226207
227208 %if (%2-%%off) >= 1
228209 %if %2 >= 4
229− movd [dstq+%2-4], mm %+ %%mmx_idx
210+ movd [dstq+%2-4], xmm %+ %%xmm_idx
230211 %elif (%2-%%off) == 1
231212 mov [dstq+%2-1], valb
232213 %elif (%2-%%off) == 2
@@ -318,11 +299,8 @@ cglobal emu_edge_vfix %+ %%n, 1, 5, 1, dst, src, start_y, end_y, bh · 85 unmodified lines
318299 %endrep ; 1+%2-%1
319300 %endmacro ; VERTICAL_EXTEND
320301
321−INIT_MMX mmx
322−VERTICAL_EXTEND 1, 15
323−
324−INIT_XMM sse
325−VERTICAL_EXTEND 16, 22
302+INIT_XMM sse2
303+VERTICAL_EXTEND 1, 22
326304
327305 ; left/right (horizontal) fast extend functions
328306 ; these are essentially identical to the vertical extend ones above,
@@ -337,11 +315,7 @@ VERTICAL_EXTEND 16, 22 · 8 unmodified lines
337315 imul vald, 0x01010101
338316 %if %1 >= 8
339317 movd m0, vald
340−%if mmsize == 16
341318 pshufd m0, m0, q0000
342−%else
343− punpckldq m0, m0
344−%endif ; mmsize == 16
345319 %endif ; %1 > 16
346320 %endif ; avx2
347321 %endmacro ; READ_V_PIXEL
@@ -356,7 +330,6 @@ VERTICAL_EXTEND 16, 22 · 8 unmodified lines
356330 %assign %%off %%off+mmsize
357331 %endrep ; %1/mmsize
358332
359−%if mmsize == 16
360333 %if %1-%%off >= 8
361334 %if %1 > 16 && %1-%%off > 8
362335 movu [%2+%1-16], m0
@@ -366,7 +339,6 @@ VERTICAL_EXTEND 16, 22 · 3 unmodified lines
366339 %assign %%off %%off+8
367340 %endif
368341 %endif ; %1-%%off >= 8
369−%endif ; mmsize == 16
370342
371343 %if %1-%%off >= 4
372344 %if %1 > 8 && %1-%%off > 4
@@ -415,11 +387,8 @@ cglobal emu_edge_hfix %+ %%n, 4, 5, 1, dst, dst_stride, start_x, bh, val · 42 unmodified lines
415387 %endrep ; 1+(%2-%1)/2
416388 %endmacro ; H_EXTEND
417389
418−INIT_MMX mmx
419−H_EXTEND 2, 14
420−
421390 INIT_XMM sse2
422−H_EXTEND 16, 22
391+H_EXTEND 2, 22
423392
424393 %if HAVE_AVX2_EXTERNAL
425394 INIT_XMM avx2
libavcodec/x86/videodsp_init.c+44−44
@@ -37,37 +37,37 @@ typedef void emu_edge_vvar_func(uint8_t *dst, x86_reg dst_stride, · 36 unmodified lines
3737 x86_reg start_y, x86_reg end_y, x86_reg bh,
3838 x86_reg w);
3939
40−extern emu_edge_vfix_func ff_emu_edge_vfix1_mmx;
41−extern emu_edge_vfix_func ff_emu_edge_vfix2_mmx;
42−extern emu_edge_vfix_func ff_emu_edge_vfix3_mmx;
43−extern emu_edge_vfix_func ff_emu_edge_vfix4_mmx;
44−extern emu_edge_vfix_func ff_emu_edge_vfix5_mmx;
45−extern emu_edge_vfix_func ff_emu_edge_vfix6_mmx;
46−extern emu_edge_vfix_func ff_emu_edge_vfix7_mmx;
47−extern emu_edge_vfix_func ff_emu_edge_vfix8_mmx;
48−extern emu_edge_vfix_func ff_emu_edge_vfix9_mmx;
49−extern emu_edge_vfix_func ff_emu_edge_vfix10_mmx;
50−extern emu_edge_vfix_func ff_emu_edge_vfix11_mmx;
51−extern emu_edge_vfix_func ff_emu_edge_vfix12_mmx;
52−extern emu_edge_vfix_func ff_emu_edge_vfix13_mmx;
53−extern emu_edge_vfix_func ff_emu_edge_vfix14_mmx;
54−extern emu_edge_vfix_func ff_emu_edge_vfix15_mmx;
55−extern emu_edge_vfix_func ff_emu_edge_vfix16_sse;
56−extern emu_edge_vfix_func ff_emu_edge_vfix17_sse;
57−extern emu_edge_vfix_func ff_emu_edge_vfix18_sse;
58−extern emu_edge_vfix_func ff_emu_edge_vfix19_sse;
59−extern emu_edge_vfix_func ff_emu_edge_vfix20_sse;
60−extern emu_edge_vfix_func ff_emu_edge_vfix21_sse;
61−extern emu_edge_vfix_func ff_emu_edge_vfix22_sse;
62−static emu_edge_vfix_func * const vfixtbl_sse[22] = {
63− ff_emu_edge_vfix1_mmx, ff_emu_edge_vfix2_mmx, ff_emu_edge_vfix3_mmx,
64− ff_emu_edge_vfix4_mmx, ff_emu_edge_vfix5_mmx, ff_emu_edge_vfix6_mmx,
65− ff_emu_edge_vfix7_mmx, ff_emu_edge_vfix8_mmx, ff_emu_edge_vfix9_mmx,
66− ff_emu_edge_vfix10_mmx, ff_emu_edge_vfix11_mmx, ff_emu_edge_vfix12_mmx,
67− ff_emu_edge_vfix13_mmx, ff_emu_edge_vfix14_mmx, ff_emu_edge_vfix15_mmx,
68− ff_emu_edge_vfix16_sse, ff_emu_edge_vfix17_sse, ff_emu_edge_vfix18_sse,
69− ff_emu_edge_vfix19_sse, ff_emu_edge_vfix20_sse, ff_emu_edge_vfix21_sse,
70− ff_emu_edge_vfix22_sse
40+extern emu_edge_vfix_func ff_emu_edge_vfix1_sse2;
41+extern emu_edge_vfix_func ff_emu_edge_vfix2_sse2;
42+extern emu_edge_vfix_func ff_emu_edge_vfix3_sse2;
43+extern emu_edge_vfix_func ff_emu_edge_vfix4_sse2;
44+extern emu_edge_vfix_func ff_emu_edge_vfix5_sse2;
45+extern emu_edge_vfix_func ff_emu_edge_vfix6_sse2;
46+extern emu_edge_vfix_func ff_emu_edge_vfix7_sse2;
47+extern emu_edge_vfix_func ff_emu_edge_vfix8_sse2;
48+extern emu_edge_vfix_func ff_emu_edge_vfix9_sse2;
49+extern emu_edge_vfix_func ff_emu_edge_vfix10_sse2;
50+extern emu_edge_vfix_func ff_emu_edge_vfix11_sse2;
51+extern emu_edge_vfix_func ff_emu_edge_vfix12_sse2;
52+extern emu_edge_vfix_func ff_emu_edge_vfix13_sse2;
53+extern emu_edge_vfix_func ff_emu_edge_vfix14_sse2;
54+extern emu_edge_vfix_func ff_emu_edge_vfix15_sse2;
55+extern emu_edge_vfix_func ff_emu_edge_vfix16_sse2;
56+extern emu_edge_vfix_func ff_emu_edge_vfix17_sse2;
57+extern emu_edge_vfix_func ff_emu_edge_vfix18_sse2;
58+extern emu_edge_vfix_func ff_emu_edge_vfix19_sse2;
59+extern emu_edge_vfix_func ff_emu_edge_vfix20_sse2;
60+extern emu_edge_vfix_func ff_emu_edge_vfix21_sse2;
61+extern emu_edge_vfix_func ff_emu_edge_vfix22_sse2;
62+static emu_edge_vfix_func * const vfixtbl_sse2[22] = {
63+ ff_emu_edge_vfix1_sse2, ff_emu_edge_vfix2_sse2, ff_emu_edge_vfix3_sse2,
64+ ff_emu_edge_vfix4_sse2, ff_emu_edge_vfix5_sse2, ff_emu_edge_vfix6_sse2,
65+ ff_emu_edge_vfix7_sse2, ff_emu_edge_vfix8_sse2, ff_emu_edge_vfix9_sse2,
66+ ff_emu_edge_vfix10_sse2, ff_emu_edge_vfix11_sse2, ff_emu_edge_vfix12_sse2,
67+ ff_emu_edge_vfix13_sse2, ff_emu_edge_vfix14_sse2, ff_emu_edge_vfix15_sse2,
68+ ff_emu_edge_vfix16_sse2, ff_emu_edge_vfix17_sse2, ff_emu_edge_vfix18_sse2,
69+ ff_emu_edge_vfix19_sse2, ff_emu_edge_vfix20_sse2, ff_emu_edge_vfix21_sse2,
70+ ff_emu_edge_vfix22_sse2
7171 };
7272 extern emu_edge_vvar_func ff_emu_edge_vvar_sse;
7373
@@ -76,21 +76,21 @@ typedef void emu_edge_hfix_func(uint8_t *dst, x86_reg dst_stride, · 2 unmodified lines
7676 typedef void emu_edge_hvar_func(uint8_t *dst, x86_reg dst_stride,
7777 x86_reg start_x, x86_reg n_words, x86_reg bh);
7878
79−extern emu_edge_hfix_func ff_emu_edge_hfix2_mmx;
80−extern emu_edge_hfix_func ff_emu_edge_hfix4_mmx;
81−extern emu_edge_hfix_func ff_emu_edge_hfix6_mmx;
82−extern emu_edge_hfix_func ff_emu_edge_hfix8_mmx;
83−extern emu_edge_hfix_func ff_emu_edge_hfix10_mmx;
84−extern emu_edge_hfix_func ff_emu_edge_hfix12_mmx;
85−extern emu_edge_hfix_func ff_emu_edge_hfix14_mmx;
79+extern emu_edge_hfix_func ff_emu_edge_hfix2_sse2;
80+extern emu_edge_hfix_func ff_emu_edge_hfix4_sse2;
81+extern emu_edge_hfix_func ff_emu_edge_hfix6_sse2;
82+extern emu_edge_hfix_func ff_emu_edge_hfix8_sse2;
83+extern emu_edge_hfix_func ff_emu_edge_hfix10_sse2;
84+extern emu_edge_hfix_func ff_emu_edge_hfix12_sse2;
85+extern emu_edge_hfix_func ff_emu_edge_hfix14_sse2;
8686 extern emu_edge_hfix_func ff_emu_edge_hfix16_sse2;
8787 extern emu_edge_hfix_func ff_emu_edge_hfix18_sse2;
8888 extern emu_edge_hfix_func ff_emu_edge_hfix20_sse2;
8989 extern emu_edge_hfix_func ff_emu_edge_hfix22_sse2;
9090 static emu_edge_hfix_func * const hfixtbl_sse2[11] = {
91− ff_emu_edge_hfix2_mmx, ff_emu_edge_hfix4_mmx, ff_emu_edge_hfix6_mmx,
92− ff_emu_edge_hfix8_mmx, ff_emu_edge_hfix10_mmx, ff_emu_edge_hfix12_mmx,
93− ff_emu_edge_hfix14_mmx, ff_emu_edge_hfix16_sse2, ff_emu_edge_hfix18_sse2,
91+ ff_emu_edge_hfix2_sse2, ff_emu_edge_hfix4_sse2, ff_emu_edge_hfix6_sse2,
92+ ff_emu_edge_hfix8_sse2, ff_emu_edge_hfix10_sse2, ff_emu_edge_hfix12_sse2,
93+ ff_emu_edge_hfix14_sse2, ff_emu_edge_hfix16_sse2, ff_emu_edge_hfix18_sse2,
9494 ff_emu_edge_hfix20_sse2, ff_emu_edge_hfix22_sse2
9595 };
9696 extern emu_edge_hvar_func ff_emu_edge_hvar_sse2;
@@ -104,7 +104,7 @@ extern emu_edge_hfix_func ff_emu_edge_hfix18_avx2; · 7 unmodified lines
104104 extern emu_edge_hfix_func ff_emu_edge_hfix20_avx2;
105105 extern emu_edge_hfix_func ff_emu_edge_hfix22_avx2;
106106 static emu_edge_hfix_func * const hfixtbl_avx2[11] = {
107− ff_emu_edge_hfix2_mmx, ff_emu_edge_hfix4_mmx, ff_emu_edge_hfix6_mmx,
107+ ff_emu_edge_hfix2_sse2, ff_emu_edge_hfix4_sse2, ff_emu_edge_hfix6_sse2,
108108 ff_emu_edge_hfix8_avx2, ff_emu_edge_hfix10_avx2, ff_emu_edge_hfix12_avx2,
109109 ff_emu_edge_hfix14_avx2, ff_emu_edge_hfix16_avx2, ff_emu_edge_hfix18_avx2,
110110 ff_emu_edge_hfix20_avx2, ff_emu_edge_hfix22_avx2
@@ -196,7 +196,7 @@ static av_noinline void emulated_edge_mc_sse2(uint8_t *buf, const uint8_t *src, · 85 unmodified lines
196196 int h)
197197 {
198198 emulated_edge_mc(buf, src, buf_stride, src_stride, block_w, block_h,
199− src_x, src_y, w, h, vfixtbl_sse, &ff_emu_edge_vvar_sse,
199+ src_x, src_y, w, h, vfixtbl_sse2, &ff_emu_edge_vvar_sse,
200200 hfixtbl_sse2, &ff_emu_edge_hvar_sse2);
201201 }
202202
@@ -209,7 +209,7 @@ static av_noinline void emulated_edge_mc_avx2(uint8_t *buf, const uint8_t *src, · 6 unmodified lines
209209 int h)
210210 {
211211 emulated_edge_mc(buf, src, buf_stride, src_stride, block_w, block_h,
212− src_x, src_y, w, h, vfixtbl_sse, &ff_emu_edge_vvar_sse,
212+ src_x, src_y, w, h, vfixtbl_sse2, &ff_emu_edge_vvar_sse,
213213 hfixtbl_avx2, &ff_emu_edge_hvar_avx2);
214214 }
215215 #endif /* HAVE_AVX2_EXTERNAL */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t