History

avformat/aiffenc: Don't forget chapters

If the write_id3v2 option is set, the aiff muxer would write id3v2 tags if there is global metadata or if there are attached pics to write. Chapters are ignored in this check that precedes writing id3v2 tags. Yet 47ac344970f1d6ef149c4b8a883b68cdb15112c2 added support for writing chapters as id3v2 tags, so one should check for the existence of chapters, too; otherwise the chapters would only be written in case there is global metadata or an attached pic.

Andreas Rheinhardt committed 6 years ago

Commit 1ebbb491 parent c7c8f141 file · +1 −1Browse files

Unified · Split

libavformat/aiffenc.c+1−1
@@ -49,7 +49,7 @@ static int put_id3v2_tags(AVFormatContext *s, AIFFOutputContext *aiff) · 48 unmodified lines
4949 AVIOContext *pb = s->pb;
5050 AVPacketList *pict_list = aiff->pict_list;
5151
52− if (!s->metadata && !aiff->pict_list)
52+ if (!s->metadata && !s->nb_chapters && !aiff->pict_list)
5353 return 0;
5454
5555 avio_wl32(pb, MKTAG('I', 'D', '3', ' '));

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t