History

configure: explicitly disable spirv_compiler

spirv_compiler is an undeclared variable that was spontaneously enabled if libshaderc or libglslang were detected, and served as a way to enable filters. However, it being undeclared had the effect that it was neither considered explicitly disabled nor enabled if libshaderc or libglslang were detected. The only category we have which explicitly disables variables is EXTERNAL_LIBRARY_LIST, however, spirv_compiler is not a real external library, and making it present there would report its detection on ./configure.

Lynne committed 2 years ago

Commit 204558c1 parent 57b7e961 file · +9 −0Browse files

Unified · Split

configure+9−0
@@ -6553,6 +6553,15 @@ if test -n "$custom_allocator"; then · 6552 unmodified lines
6553 add_extralibs "$custom_allocator_extralibs"6553 add_extralibs "$custom_allocator_extralibs"
6554fi6554fi
6555 6555
6556# Unlike other feature flags or libraries, spirv_compiler is not defined
6557# within any of our predefined categories of components.
6558# It gets defined if either libshaderc or libglslang check succeeds.
6559# As such, its in a state of neither being explicitly enabled, nor
6560# explicitly disabled, but even in this state, being mentioned in
6561# _deps results in it always passing.
6562# Disable it explicitly to fix this.
6563disable spirv_compiler
6564
6556check_func_headers malloc.h _aligned_malloc && enable aligned_malloc6565check_func_headers malloc.h _aligned_malloc && enable aligned_malloc
6557check_func ${malloc_prefix}memalign && enable memalign6566check_func ${malloc_prefix}memalign && enable memalign
6558check_func ${malloc_prefix}posix_memalign && enable posix_memalign6567check_func ${malloc_prefix}posix_memalign && enable posix_memalign

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t