History

avcodec/dct: Make declarations and definitions match

GCC considers declarations using a parameter of pointer type (or equivalently a parameter using an array of unspecified dimensions) to be inconsistent with a declaration using a known-length array type and emits a -Warray-parameter warning for several ff_j_rev_dct* functions for this. This patch makes the declarations match the actual definitions to suppress these (IMO nonsensical) warnings.

Andreas Rheinhardt committed 1 year ago

Commit 2204efc1 parent 839b4192 files · +8 −8Browse files

Unified · Split

2 files
  1. libavcodec/dct.h +6 −6
  2. libavcodec/jrevdct.c +2 −2
libavcodec/dct.h+6−6
@@ -27,11 +27,11 @@ · 26 unmodified lines
2727 #include <stddef.h>
2828 #include <stdint.h>
2929
30−void ff_j_rev_dct(int16_t *data);
31−void ff_j_rev_dct4(int16_t *data);
32−void ff_j_rev_dct2(int16_t *data);
33−void ff_j_rev_dct1(int16_t *data);
34−void ff_jref_idct_put(uint8_t *dest, ptrdiff_t line_size, int16_t *block);
35−void ff_jref_idct_add(uint8_t *dest, ptrdiff_t line_size, int16_t *block);
30+void ff_j_rev_dct(int16_t data[64]);
31+void ff_j_rev_dct4(int16_t data[64]);
32+void ff_j_rev_dct2(int16_t data[64]);
33+void ff_j_rev_dct1(int16_t data[64]);
34+void ff_jref_idct_put(uint8_t *dest, ptrdiff_t line_size, int16_t block[64]);
35+void ff_jref_idct_add(uint8_t *dest, ptrdiff_t line_size, int16_t block[64]);
3636
3737 #endif /* AVCODEC_DCT_H */
libavcodec/jrevdct.c+2−2
@@ -1159,13 +1159,13 @@ void ff_j_rev_dct1(DCTBLOCK data){ · 1158 unmodified lines
11591159 #undef FIX
11601160 #undef CONST_BITS
11611161
1162−void ff_jref_idct_put(uint8_t *dest, ptrdiff_t line_size, int16_t *block)
1162+void ff_jref_idct_put(uint8_t *dest, ptrdiff_t line_size, int16_t block[64])
11631163 {
11641164 ff_j_rev_dct(block);
11651165 ff_put_pixels_clamped_c(block, dest, line_size);
11661166 }
11671167
1168−void ff_jref_idct_add(uint8_t *dest, ptrdiff_t line_size, int16_t *block)
1168+void ff_jref_idct_add(uint8_t *dest, ptrdiff_t line_size, int16_t block[64])
11691169 {
11701170 ff_j_rev_dct(block);
11711171 ff_add_pixels_clamped_c(block, dest, line_size);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t