History

avformat: fix AVStream private fields marker

Public fields were added after the private fields (negating the entire point of this). New private fields go into AVStreamInternal anyway. The new marker was set by guessing which fields are supposed to be private and wshich not. recommended_encoder_configuration is accessed by ffserver_config.c directly, and is supposed to use the public API. ffmpeg.c accesses AVStream.cur_dts, even though it's a private field, but that seems to be an older error.

wm4 committed 9 years ago

Commit 227f6e11 parent 554bc4e1 file · +9 −1Browse files

Unified · Split

libavformat/avformat.h+9−1
@@ -1005,7 +1005,9 @@ typedef struct AVStream { · 1004 unmodified lines
10051005 * All fields below this line are not part of the public API. They
10061006 * may not be used outside of libavformat and can be changed and
10071007 * removed at will.
1008− * New public fields should be added right above.
1008+ * Internal note: be aware that physically removing these fields
1009+ * will break ABI. Replace removed fields with dummy fields, and
1010+ * add new fields to AVStreamInternal.
10091011 *****************************************************************
10101012 */
10111013
@@ -1201,6 +1203,12 @@ typedef struct AVStream { · 189 unmodified lines
12011203 */
12021204 int inject_global_side_data;
12031205
1206+ /*****************************************************************
1207+ * All fields above this line are not part of the public API.
1208+ * Fields below are part of the public API and ABI again.
1209+ *****************************************************************
1210+ */
1211+
12041212 /**
12051213 * String containing paris of key and values describing recommended encoder configuration.
12061214 * Paris are separated by ','.

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t