History

avcodec/mpegvideo_enc: Limit bitrate tolerance to the representable

Fixes: error: 1.66789e+11 is outside the range of representable values of type 'int' Fixes: Ticket8201

Michael Niedermayer committed 5 years ago

Commit 245017e1 parent 48bbeac1 file · +5 −1Browse files

Unified · Split

libavcodec/mpegvideo_enc.c+5−1
@@ -463,9 +463,13 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx) · 462 unmodified lines
463463 if (!s->fixed_qscale &&
464464 avctx->bit_rate * av_q2d(avctx->time_base) >
465465 avctx->bit_rate_tolerance) {
466+ double nbt = avctx->bit_rate * av_q2d(avctx->time_base) * 5;
466467 av_log(avctx, AV_LOG_WARNING,
467468 "bitrate tolerance %d too small for bitrate %"PRId64", overriding\n", avctx->bit_rate_tolerance, avctx->bit_rate);
468− avctx->bit_rate_tolerance = 5 * avctx->bit_rate * av_q2d(avctx->time_base);
469+ if (nbt <= INT_MAX) {
470+ avctx->bit_rate_tolerance = nbt;
471+ } else
472+ avctx->bit_rate_tolerance = INT_MAX;
469473 }
470474
471475 if (avctx->rc_max_rate &&

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t