History

mfenc: Fix building with clang in MSVC mode

Just including icodecapi.h + codecapi.h apparently misses some bits, that MSVC doesn't complain about, but Clang does. Thus add a missing header to the custom hacky include path (required for keeping ICodecAPI visible when building in UWP mode, as it is intended to). The issue in Windows SDK headers about ICodecAPI availability in UWP/app mode has been reported upstream at https://developercommunity.visualstudio.com/content/problem/1037125/icodecapi-not-visible-when-compiling-in-uwp-mode.html, and later also filed in Feedback Hub (which can't be linked to externally).

Martin Storsjö committed 6 years ago

Commit 2a1fd3c1 parent 727cac81 file · +3 −0Browse files

Showing the changes to libavcodec (1 of 1 file). Show all

Unified · Split

libavcodec/mf_utils.h+3−0
@@ -28,6 +28,9 @@ · 27 unmodified lines
28// of including it though, through strmif.h via dshow.h. And on mingw, the28// of including it though, through strmif.h via dshow.h. And on mingw, the
29// mf*.h headers below indirectly include strmif.h.)29// mf*.h headers below indirectly include strmif.h.)
30#include <icodecapi.h>30#include <icodecapi.h>
31// Clang in MSVC mode fails on codecapi.h if we haven't included uuids.h
32// before, while it seems to work fine with MSVC itself.
33#include <uuids.h>
31#else34#else
32#include <dshow.h>35#include <dshow.h>
33#endif36#endif

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t