History

avcodec/hevc_ps: Check delta_pocs in ff_hevc_decode_short_term_rps()

Fixes: integer overflow Fixes: 2893/clusterfuzz-testcase-minimized-5809330567774208

Michael Niedermayer committed 9 years ago

Commit 2b44dcb1 parent 37e8edc1 file · +12 −0Browse files

Showing the changes to libavcodec (1 of 1 file). Show all

Unified · Split

libavcodec/hevc_ps.c+12−0
@@ -225,6 +225,12 @@ int ff_hevc_decode_short_term_rps(GetBitContext *gb, AVCodecContext *avctx, · 224 unmodified lines
225 prev = 0;225 prev = 0;
226 for (i = 0; i < rps->num_negative_pics; i++) {226 for (i = 0; i < rps->num_negative_pics; i++) {
227 delta_poc = get_ue_golomb_long(gb) + 1;227 delta_poc = get_ue_golomb_long(gb) + 1;
228 if (delta_poc < 1 || delta_poc > 32768) {
229 av_log(avctx, AV_LOG_ERROR,
230 "Invalid value of delta_poc: %d\n",
231 delta_poc);
232 return AVERROR_INVALIDDATA;
233 }
228 prev -= delta_poc;234 prev -= delta_poc;
229 rps->delta_poc[i] = prev;235 rps->delta_poc[i] = prev;
230 rps->used[i] = get_bits1(gb);236 rps->used[i] = get_bits1(gb);
@@ -232,6 +238,12 @@ int ff_hevc_decode_short_term_rps(GetBitContext *gb, AVCodecContext *avctx, · 1 unmodified line
232 prev = 0;238 prev = 0;
233 for (i = 0; i < nb_positive_pics; i++) {239 for (i = 0; i < nb_positive_pics; i++) {
234 delta_poc = get_ue_golomb_long(gb) + 1;240 delta_poc = get_ue_golomb_long(gb) + 1;
241 if (delta_poc < 1 || delta_poc > 32768) {
242 av_log(avctx, AV_LOG_ERROR,
243 "Invalid value of delta_poc: %d\n",
244 delta_poc);
245 return AVERROR_INVALIDDATA;
246 }
235 prev += delta_poc;247 prev += delta_poc;
236 rps->delta_poc[rps->num_negative_pics + i] = prev;248 rps->delta_poc[rps->num_negative_pics + i] = prev;
237 rps->used[rps->num_negative_pics + i] = get_bits1(gb);249 rps->used[rps->num_negative_pics + i] = get_bits1(gb);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t