History

avcodec/flacdsp: Fix integer-overflow in flac_lpc_33_c

This fix copies a couple of casts from surrounding functions. See https://crbug.com/432528781 for stack trace details.

Dale Curtis committed 1 year ago

Commit 2ddc3cb1 parent 9d8469e1 file · +1 −1Browse files

Showing the changes to libavcodec (1 of 1 file). Show all

Unified · Split

libavcodec/flacdsp.c+1−1
@@ -94,7 +94,7 @@ static void flac_lpc_33_c(int64_t *decoded, const int32_t *residual, · 93 unmodified lines
94 int64_t sum = 0;94 int64_t sum = 0;
95 for (j = 0; j < pred_order; j++)95 for (j = 0; j < pred_order; j++)
96 sum += (int64_t)coeffs[j] * (uint64_t)decoded[j];96 sum += (int64_t)coeffs[j] * (uint64_t)decoded[j];
97 decoded[j] = residual[i] + (sum >> qlevel);97 decoded[j] = (uint64_t)residual[i] + (uint64_t)(sum >> qlevel);
98 }98 }
99}99}
100 100

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t