History

idct: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar.

Diego Biurrun committed 10 years ago

Commit 2ec9fa51 parent b2939a736 files · +184 −166Browse files

Showing the changes to libavcodec/arm (8 of 36 files). Show all

Unified · Split

8 files
  1. libavcodec/arm/idct.h +7 −6
  2. libavcodec/arm/idctdsp_arm.S +1 −1
  3. libavcodec/arm/idctdsp_init_arm.c +10 −5
  4. libavcodec/arm/idctdsp_init_armv6.c +1 −1
  5. libavcodec/arm/simple_idct_armv6.S +2 −2
  6. libavcodec/arm/simple_idct_neon.S +2 −2
  7. libavcodec/arm/vc1dsp_init_neon.c +7 −7
  8. libavcodec/arm/vc1dsp_neon.S +3 −3
libavcodec/arm/idct.h+7−6
@@ -19,6 +19,7 @@ · 18 unmodified lines
1919 #ifndef AVCODEC_ARM_IDCT_H
2020 #define AVCODEC_ARM_IDCT_H
2121
22+#include <stddef.h>
2223 #include <stdint.h>
2324
2425 void ff_j_rev_dct_arm(int16_t *data);
@@ -26,15 +27,15 @@ void ff_j_rev_dct_arm(int16_t *data); · 1 unmodified line
2627 void ff_simple_idct_arm(int16_t *data);
2728
2829 void ff_simple_idct_armv5te(int16_t *data);
29−void ff_simple_idct_put_armv5te(uint8_t *dest, int line_size, int16_t *data);
30−void ff_simple_idct_add_armv5te(uint8_t *dest, int line_size, int16_t *data);
30+void ff_simple_idct_put_armv5te(uint8_t *dest, ptrdiff_t line_size, int16_t *data);
31+void ff_simple_idct_add_armv5te(uint8_t *dest, ptrdiff_t line_size, int16_t *data);
3132
3233 void ff_simple_idct_armv6(int16_t *data);
33−void ff_simple_idct_put_armv6(uint8_t *dest, int line_size, int16_t *data);
34−void ff_simple_idct_add_armv6(uint8_t *dest, int line_size, int16_t *data);
34+void ff_simple_idct_put_armv6(uint8_t *dest, ptrdiff_t line_size, int16_t *data);
35+void ff_simple_idct_add_armv6(uint8_t *dest, ptrdiff_t line_size, int16_t *data);
3536
3637 void ff_simple_idct_neon(int16_t *data);
37−void ff_simple_idct_put_neon(uint8_t *dest, int line_size, int16_t *data);
38−void ff_simple_idct_add_neon(uint8_t *dest, int line_size, int16_t *data);
38+void ff_simple_idct_put_neon(uint8_t *dest, ptrdiff_t line_size, int16_t *data);
39+void ff_simple_idct_add_neon(uint8_t *dest, ptrdiff_t line_size, int16_t *data);
3940
4041 #endif /* AVCODEC_ARM_IDCT_H */
libavcodec/arm/idctdsp_arm.S+1−1
@@ -22,7 +22,7 @@ · 21 unmodified lines
2222 #include "config.h"
2323 #include "libavutil/arm/asm.S"
2424
25−@ void ff_add_pixels_clamped_arm(int16_t *block, uint8_t *dest, int stride)
25+@ void ff_add_pixels_clamped_arm(int16_t *block, uint8_t *dest, ptrdiff_t stride)
2626 function ff_add_pixels_clamped_arm, export=1, align=5
2727 push {r4-r10}
2828 mov r10, #8
libavcodec/arm/idctdsp_init_arm.c+10−5
@@ -19,6 +19,7 @@ · 18 unmodified lines
1919 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2020 */
2121
22+#include <stddef.h>
2223 #include <stdint.h>
2324
2425 #include "libavutil/attributes.h"
@@ -30,29 +31,33 @@ · 5 unmodified lines
3031 #include "idctdsp_arm.h"
3132
3233 void ff_add_pixels_clamped_arm(const int16_t *block, uint8_t *dest,
33− int line_size);
34+ ptrdiff_t line_size);
3435
3536 /* XXX: those functions should be suppressed ASAP when all IDCTs are
3637 * converted */
37−static void j_rev_dct_arm_put(uint8_t *dest, int line_size, int16_t *block)
38+static void j_rev_dct_arm_put(uint8_t *dest, ptrdiff_t line_size,
39+ int16_t *block)
3840 {
3941 ff_j_rev_dct_arm(block);
4042 ff_put_pixels_clamped(block, dest, line_size);
4143 }
4244
43−static void j_rev_dct_arm_add(uint8_t *dest, int line_size, int16_t *block)
45+static void j_rev_dct_arm_add(uint8_t *dest, ptrdiff_t line_size,
46+ int16_t *block)
4447 {
4548 ff_j_rev_dct_arm(block);
4649 ff_add_pixels_clamped(block, dest, line_size);
4750 }
4851
49−static void simple_idct_arm_put(uint8_t *dest, int line_size, int16_t *block)
52+static void simple_idct_arm_put(uint8_t *dest, ptrdiff_t line_size,
53+ int16_t *block)
5054 {
5155 ff_simple_idct_arm(block);
5256 ff_put_pixels_clamped(block, dest, line_size);
5357 }
5458
55−static void simple_idct_arm_add(uint8_t *dest, int line_size, int16_t *block)
59+static void simple_idct_arm_add(uint8_t *dest, ptrdiff_t line_size,
60+ int16_t *block)
5661 {
5762 ff_simple_idct_arm(block);
5863 ff_add_pixels_clamped(block, dest, line_size);
libavcodec/arm/idctdsp_init_armv6.c+1−1
@@ -27,7 +27,7 @@ · 26 unmodified lines
2727 #include "idctdsp_arm.h"
2828
2929 void ff_add_pixels_clamped_armv6(const int16_t *block, uint8_t *pixels,
30− int line_size);
30+ ptrdiff_t line_size);
3131
3232 av_cold void ff_idctdsp_init_armv6(IDCTDSPContext *c, AVCodecContext *avctx,
3333 unsigned high_bit_depth)
libavcodec/arm/simple_idct_armv6.S+2−2
@@ -390,7 +390,7 @@ function ff_simple_idct_armv6, export=1 · 389 unmodified lines
390390 pop {r4-r11, pc}
391391 endfunc
392392
393−/* ff_simple_idct_add_armv6(uint8_t *dest, int line_size, int16_t *data); */
393+/* ff_simple_idct_add_armv6(uint8_t *dest, ptrdiff_t line_size, int16_t *data); */
394394 function ff_simple_idct_add_armv6, export=1
395395 push {r0, r1, r4-r11, lr}
396396 sub sp, sp, #128
@@ -407,7 +407,7 @@ function ff_simple_idct_add_armv6, export=1 · 10 unmodified lines
407407 pop {r4-r11, pc}
408408 endfunc
409409
410−/* ff_simple_idct_put_armv6(uint8_t *dest, int line_size, int16_t *data); */
410+/* ff_simple_idct_put_armv6(uint8_t *dest, ptrdiff_t line_size, int16_t *data); */
411411 function ff_simple_idct_put_armv6, export=1
412412 push {r0, r1, r4-r11, lr}
413413 sub sp, sp, #128
libavcodec/arm/simple_idct_neon.S+2−2
@@ -261,7 +261,7 @@ endconst · 260 unmodified lines
261261 pop {r4-r7, pc}
262262 .endm
263263
264−/* void ff_simple_idct_put_neon(uint8_t *dst, int line_size, int16_t *data); */
264+/* void ff_simple_idct_put_neon(uint8_t *dst, ptrdiff_t line_size, int16_t *data); */
265265 function ff_simple_idct_put_neon, export=1
266266 idct_start r2
267267
@@ -316,7 +316,7 @@ function idct_col4_add8_neon · 48 unmodified lines
316316 bx lr
317317 endfunc
318318
319−/* void ff_simple_idct_add_neon(uint8_t *dst, int line_size, int16_t *data); */
319+/* void ff_simple_idct_add_neon(uint8_t *dst, ptrdiff_t line_size, int16_t *data); */
320320 function ff_simple_idct_add_neon, export=1
321321 idct_start r2
322322
libavcodec/arm/vc1dsp_init_neon.c+7−7
@@ -25,14 +25,14 @@ · 24 unmodified lines
2525 #include "config.h"
2626
2727 void ff_vc1_inv_trans_8x8_neon(int16_t *block);
28−void ff_vc1_inv_trans_4x8_neon(uint8_t *dest, int linesize, int16_t *block);
29−void ff_vc1_inv_trans_8x4_neon(uint8_t *dest, int linesize, int16_t *block);
30−void ff_vc1_inv_trans_4x4_neon(uint8_t *dest, int linesize, int16_t *block);
28+void ff_vc1_inv_trans_4x8_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
29+void ff_vc1_inv_trans_8x4_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
30+void ff_vc1_inv_trans_4x4_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
3131
32−void ff_vc1_inv_trans_8x8_dc_neon(uint8_t *dest, int linesize, int16_t *block);
33−void ff_vc1_inv_trans_4x8_dc_neon(uint8_t *dest, int linesize, int16_t *block);
34−void ff_vc1_inv_trans_8x4_dc_neon(uint8_t *dest, int linesize, int16_t *block);
35−void ff_vc1_inv_trans_4x4_dc_neon(uint8_t *dest, int linesize, int16_t *block);
32+void ff_vc1_inv_trans_8x8_dc_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
33+void ff_vc1_inv_trans_4x8_dc_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
34+void ff_vc1_inv_trans_8x4_dc_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
35+void ff_vc1_inv_trans_4x4_dc_neon(uint8_t *dest, ptrdiff_t stride, int16_t *block);
3636
3737 void ff_put_pixels8x8_neon(uint8_t *block, const uint8_t *pixels,
3838 ptrdiff_t line_size, int rnd);
libavcodec/arm/vc1dsp_neon.S+3−3
@@ -426,7 +426,7 @@ function ff_vc1_inv_trans_8x8_neon, export=1 · 425 unmodified lines
426426 bx lr
427427 endfunc
428428
429−@ (uint8_t *dest [r0], int linesize [r1], int16_t *block [r2])
429+@ (uint8_t *dest [r0], ptrdiff_t stride [r1], int16_t *block [r2])
430430 function ff_vc1_inv_trans_8x4_neon, export=1
431431 vld1.64 {q0-q1}, [r2,:128]! @ load 8 * 4 * 2 = 64 bytes / 16 bytes per quad = 4 quad registers
432432 vld1.64 {q2-q3}, [r2,:128]
@@ -511,7 +511,7 @@ function ff_vc1_inv_trans_8x4_neon, export=1 · 78 unmodified lines
511511 bx lr
512512 endfunc
513513
514−@ (uint8_t *dest [r0], int linesize [r1], int16_t *block [r2])
514+@ (uint8_t *dest [r0], ptrdiff_t stride [r1], int16_t *block [r2])
515515 function ff_vc1_inv_trans_4x8_neon, export=1
516516 mov r12, #(8 * 2) @ 8 elements per line, each element 2 bytes
517517 vld4.16 {d0[], d2[], d4[], d6[]}, [r2,:64], r12 @ read each column into a q register
@@ -593,7 +593,7 @@ endfunc · 75 unmodified lines
593593 vshr.s16 q1, q1, #\rshift @ dst[3,1] >>= rshift
594594 .endm
595595
596−@ (uint8_t *dest [r0], int linesize [r1], int16_t *block [r2])
596+@ (uint8_t *dest [r0], ptrdiff_t stride [r1], int16_t *block [r2])
597597 function ff_vc1_inv_trans_4x4_neon, export=1
598598 mov r12, #(8 * 2) @ 8 elements per line, each element 2 bytes
599599 vld4.16 {d0[], d1[], d2[], d3[]}, [r2,:64], r12 @ read each column into a register

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t