The query_formats function of the channelmap filter tries to allocate a list of channel layouts which on success are attached to more permanent objects (an AVFilterLink) for storage afterwards. If attaching succeeds, the link becomes one of the common owners (in this case, the only owner) of the list. Yet if the list has been successfully attached to the link and an error happens lateron, the list was manually freed, which is wrong, because it is owned by its link so that the link's pointer to the list will become dangling and there will be a double-free/use-after-free when the link is later cleaned up automatically. This commit fixes this by removing the custom freeing code; this will temporarily add a leaking codepath (if attaching the list fails, the list will leak), but this will be fixed soon by making sure that an AVFilterChannelLayouts without owner will be automatically freed when attaching it to an AVFilterLink fails.
Unified · Split
| @@ -280,28 +280,18 @@ static av_cold int channelmap_init(AVFilterContext *ctx) · 279 unmodified lines | |||
| 280 | static int channelmap_query_formats(AVFilterContext *ctx) | 280 | static int channelmap_query_formats(AVFilterContext *ctx) |
| 281 | { | 281 | { |
| 282 | ChannelMapContext *s = ctx->priv; | 282 | ChannelMapContext *s = ctx->priv; |
| 283 | AVFilterChannelLayouts *layouts; | ||
| 284 | AVFilterChannelLayouts *channel_layouts = NULL; | 283 | AVFilterChannelLayouts *channel_layouts = NULL; |
| 285 | int ret; | 284 | int ret; |
| 286 | 285 | ||
| 287 | layouts = ff_all_channel_counts(); | 286 | if ((ret = ff_set_common_formats (ctx, ff_planar_sample_fmts())) < 0 || |
| 288 | if (!layouts) { | ||
| 289 | ret = AVERROR(ENOMEM); | ||
| 290 | goto fail; | ||
| 291 | } | ||
| 292 | if ((ret = ff_add_channel_layout (&channel_layouts, s->output_layout )) < 0 || | ||
| 293 | (ret = ff_set_common_formats (ctx , ff_planar_sample_fmts() )) < 0 || | ||
| 294 | (ret = ff_set_common_samplerates (ctx , ff_all_samplerates() )) < 0 || | 287 | (ret = ff_set_common_samplerates (ctx , ff_all_samplerates() )) < 0 || |
| 295 | (ret = ff_channel_layouts_ref (layouts , &ctx->inputs[0]->out_channel_layouts)) < 0 || | 288 | (ret = ff_add_channel_layout(&channel_layouts, s->output_layout)) < 0 || |
| 296 | (ret = ff_channel_layouts_ref (channel_layouts , &ctx->outputs[0]->in_channel_layouts)) < 0) | 289 | (ret = ff_channel_layouts_ref(channel_layouts, |
| 297 | goto fail; | 290 | &ctx->outputs[0]->in_channel_layouts)) < 0) |
| 291 | return ret; | ||
| 298 | 292 | ||
| 299 | return 0; | 293 | return ff_channel_layouts_ref(ff_all_channel_counts(), |
| 300 | fail: | 294 | &ctx->inputs[0]->out_channel_layouts); |
| 301 | if (layouts) | ||
| 302 | av_freep(&layouts->channel_layouts); | ||
| 303 | av_freep(&layouts); | ||
| 304 | return ret; | ||
| 305 | } | 295 | } |
| 306 | 296 | ||
| 307 | static int channelmap_filter_frame(AVFilterLink *inlink, AVFrame *buf) | 297 | static int channelmap_filter_frame(AVFilterLink *inlink, AVFrame *buf) |