History

avcodec/cbs_h266_syntax_template: Don't omit unused function parameter

The calls to the sei_decoded_picture_hash read and write functions are performed with four pointer arguments; just because one of them is unused by the callees does not mean that they can be omitted: This is undefined behaviour. (This was not recognized because the SEI_MESSAGE_RW macro contains casts.)

Andreas Rheinhardt committed 2 years ago

Commit 484e7711 parent b31ee081 file · +1 −1Browse files

Unified · Split

libavcodec/cbs_h266_syntax_template.c+1−1
@@ -3430,7 +3430,7 @@ static int FUNC(slice_header) (CodedBitstreamContext *ctx, RWContext *rw, · 3429 unmodified lines
3430static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx,3430static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx,
3431 RWContext *rw,3431 RWContext *rw,
3432 H266RawSEIDecodedPictureHash *3432 H266RawSEIDecodedPictureHash *
3433 current)3433 current, SEIMessageState *unused)
3434{3434{
3435 int err, c_idx, i;3435 int err, c_idx, i;
3436 3436

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t