The calls to the sei_decoded_picture_hash read and write functions are performed with four pointer arguments; just because one of them is unused by the callees does not mean that they can be omitted: This is undefined behaviour. (This was not recognized because the SEI_MESSAGE_RW macro contains casts.)
Showing the changes to libavcodec (1 of 1 file). Show all
Unified · Split
| @@ -3430,7 +3430,7 @@ static int FUNC(slice_header) (CodedBitstreamContext *ctx, RWContext *rw, · 3429 unmodified lines | |||
| 3430 | static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx, | 3430 | static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx, |
| 3431 | RWContext *rw, | 3431 | RWContext *rw, |
| 3432 | H266RawSEIDecodedPictureHash * | 3432 | H266RawSEIDecodedPictureHash * |
| 3433 | current) | 3433 | current, SEIMessageState *unused) |
| 3434 | { | 3434 | { |
| 3435 | int err, c_idx, i; | 3435 | int err, c_idx, i; |
| 3436 | 3436 | ||