History

avfilter/x86/vf_yadif: Remove obsolete MMXEXT functions

The only system which benefit from these are truely ancient 32bit x86s as all other systems use at least the SSE2 versions (this includes all x64 cpus (which is why this code is restricted to x86-32)).

Andreas Rheinhardt committed 4 years ago

Commit 4d7128b1 parent 19abc4c4 files · +0 −37Browse files

Showing the changes to libavfilter (4 of 4 files). Show all

Unified · Split

4 files
  1. libavfilter/x86/vf_yadif.asm +0 −8
  2. libavfilter/x86/vf_yadif_init.c +0 −21
  3. libavfilter/x86/yadif-10.asm +0 −4
  4. libavfilter/x86/yadif-16.asm +0 −4
libavfilter/x86/vf_yadif.asm+0−8
@@ -133,12 +133,8 @@ SECTION .text · 132 unmodified lines
133 psubusb m2, m3133 psubusb m2, m3
134 psubusb m3, m4134 psubusb m3, m4
135 pmaxub m2, m3135 pmaxub m2, m3
136%if mmsize == 16
137 mova m3, m2136 mova m3, m2
138 psrldq m3, 2137 psrldq m3, 2
139%else
140 pshufw m3, m2, q0021
141%endif
142 punpcklbw m2, m7138 punpcklbw m2, m7
143 punpcklbw m3, m7139 punpcklbw m3, m7
144 paddw m0, m2140 paddw m0, m2
@@ -237,7 +233,3 @@ INIT_XMM ssse3 · 92 unmodified lines
237YADIF233YADIF
238INIT_XMM sse2234INIT_XMM sse2
239YADIF235YADIF
240%if ARCH_X86_32
241INIT_MMX mmxext
242YADIF
243%endif
libavfilter/x86/vf_yadif_init.c+0−21
@@ -23,9 +23,6 @@ · 22 unmodified lines
23#include "libavutil/x86/cpu.h"23#include "libavutil/x86/cpu.h"
24#include "libavfilter/yadif.h"24#include "libavfilter/yadif.h"
25 25
26void ff_yadif_filter_line_mmxext(void *dst, void *prev, void *cur,
27 void *next, int w, int prefs,
28 int mrefs, int parity, int mode);
29void ff_yadif_filter_line_sse2(void *dst, void *prev, void *cur,26void ff_yadif_filter_line_sse2(void *dst, void *prev, void *cur,
30 void *next, int w, int prefs,27 void *next, int w, int prefs,
31 int mrefs, int parity, int mode);28 int mrefs, int parity, int mode);
@@ -33,9 +30,6 @@ void ff_yadif_filter_line_ssse3(void *dst, void *prev, void *cur, · 1 unmodified line
33 void *next, int w, int prefs,30 void *next, int w, int prefs,
34 int mrefs, int parity, int mode);31 int mrefs, int parity, int mode);
35 32
36void ff_yadif_filter_line_16bit_mmxext(void *dst, void *prev, void *cur,
37 void *next, int w, int prefs,
38 int mrefs, int parity, int mode);
39void ff_yadif_filter_line_16bit_sse2(void *dst, void *prev, void *cur,33void ff_yadif_filter_line_16bit_sse2(void *dst, void *prev, void *cur,
40 void *next, int w, int prefs,34 void *next, int w, int prefs,
41 int mrefs, int parity, int mode);35 int mrefs, int parity, int mode);
@@ -46,9 +40,6 @@ void ff_yadif_filter_line_16bit_sse4(void *dst, void *prev, void *cur, · 4 unmodified lines
46 void *next, int w, int prefs,40 void *next, int w, int prefs,
47 int mrefs, int parity, int mode);41 int mrefs, int parity, int mode);
48 42
49void ff_yadif_filter_line_10bit_mmxext(void *dst, void *prev, void *cur,
50 void *next, int w, int prefs,
51 int mrefs, int parity, int mode);
52void ff_yadif_filter_line_10bit_sse2(void *dst, void *prev, void *cur,43void ff_yadif_filter_line_10bit_sse2(void *dst, void *prev, void *cur,
53 void *next, int w, int prefs,44 void *next, int w, int prefs,
54 int mrefs, int parity, int mode);45 int mrefs, int parity, int mode);
@@ -63,10 +54,6 @@ av_cold void ff_yadif_init_x86(YADIFContext *yadif) · 8 unmodified lines
63 : yadif->csp->comp[0].depth;54 : yadif->csp->comp[0].depth;
64 55
65 if (bit_depth >= 15) {56 if (bit_depth >= 15) {
66#if ARCH_X86_32
67 if (EXTERNAL_MMXEXT(cpu_flags))
68 yadif->filter_line = ff_yadif_filter_line_16bit_mmxext;
69#endif /* ARCH_X86_32 */
70 if (EXTERNAL_SSE2(cpu_flags))57 if (EXTERNAL_SSE2(cpu_flags))
71 yadif->filter_line = ff_yadif_filter_line_16bit_sse2;58 yadif->filter_line = ff_yadif_filter_line_16bit_sse2;
72 if (EXTERNAL_SSSE3(cpu_flags))59 if (EXTERNAL_SSSE3(cpu_flags))
@@ -74,19 +61,11 @@ av_cold void ff_yadif_init_x86(YADIFContext *yadif) · 1 unmodified line
74 if (EXTERNAL_SSE4(cpu_flags))61 if (EXTERNAL_SSE4(cpu_flags))
75 yadif->filter_line = ff_yadif_filter_line_16bit_sse4;62 yadif->filter_line = ff_yadif_filter_line_16bit_sse4;
76 } else if ( bit_depth >= 9 && bit_depth <= 14) {63 } else if ( bit_depth >= 9 && bit_depth <= 14) {
77#if ARCH_X86_32
78 if (EXTERNAL_MMXEXT(cpu_flags))
79 yadif->filter_line = ff_yadif_filter_line_10bit_mmxext;
80#endif /* ARCH_X86_32 */
81 if (EXTERNAL_SSE2(cpu_flags))64 if (EXTERNAL_SSE2(cpu_flags))
82 yadif->filter_line = ff_yadif_filter_line_10bit_sse2;65 yadif->filter_line = ff_yadif_filter_line_10bit_sse2;
83 if (EXTERNAL_SSSE3(cpu_flags))66 if (EXTERNAL_SSSE3(cpu_flags))
84 yadif->filter_line = ff_yadif_filter_line_10bit_ssse3;67 yadif->filter_line = ff_yadif_filter_line_10bit_ssse3;
85 } else {68 } else {
86#if ARCH_X86_32
87 if (EXTERNAL_MMXEXT(cpu_flags))
88 yadif->filter_line = ff_yadif_filter_line_mmxext;
89#endif /* ARCH_X86_32 */
90 if (EXTERNAL_SSE2(cpu_flags))69 if (EXTERNAL_SSE2(cpu_flags))
91 yadif->filter_line = ff_yadif_filter_line_sse2;70 yadif->filter_line = ff_yadif_filter_line_sse2;
92 if (EXTERNAL_SSSE3(cpu_flags))71 if (EXTERNAL_SSSE3(cpu_flags))
libavfilter/x86/yadif-10.asm+0−4
@@ -249,7 +249,3 @@ INIT_XMM ssse3 · 248 unmodified lines
249YADIF249YADIF
250INIT_XMM sse2250INIT_XMM sse2
251YADIF251YADIF
252%if ARCH_X86_32
253INIT_MMX mmxext
254YADIF
255%endif
libavfilter/x86/yadif-16.asm+0−4
@@ -287,7 +287,3 @@ INIT_XMM ssse3 · 286 unmodified lines
287YADIF287YADIF
288INIT_XMM sse2288INIT_XMM sse2
289YADIF289YADIF
290%if ARCH_X86_32
291INIT_MMX mmxext
292YADIF
293%endif

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t