History

fftools: do not access out of bounds filtergraph

The log message was logged for `filtergraphs[j]` which would cause a heap buffer overflow in certain circumstances. Correctly it should be logged for the current filtergraph, so just use `fg` here.

Marvin Scholz committed 2 years ago

Commit 5beeb3a1 parent ac092c61 file · +1 −1Browse files

Unified · Split

fftools/ffmpeg_filter.c+1−1
@@ -1409,7 +1409,7 @@ int fg_finalise_bindings(void) · 1408 unmodified lines
1409 for (int j = 0; j < fg->nb_outputs; j++) {1409 for (int j = 0; j < fg->nb_outputs; j++) {
1410 OutputFilter *output = fg->outputs[j];1410 OutputFilter *output = fg->outputs[j];
1411 if (!output->bound) {1411 if (!output->bound) {
1412 av_log(filtergraphs[j], AV_LOG_FATAL,1412 av_log(fg, AV_LOG_FATAL,
1413 "Filter %s has an unconnected output\n", output->name);1413 "Filter %s has an unconnected output\n", output->name);
1414 return AVERROR(EINVAL);1414 return AVERROR(EINVAL);
1415 }1415 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t