History

avfiltergraph: shut up uninitialized variable warning.

The warning silenced was: libavfilter/avfiltergraph.c: In function ‘avfilter_graph_config’: libavfilter/avfiltergraph.c:500:13: warning: ‘best_idx’ may be used uninitialized in this function [-Wuninitialized]

Anton Khirnov committed 14 years ago

Commit 61d158c1 parent fd2784c1 file · +3 −1Browse files

Showing the changes to libavfilter/avfiltergraph.c (1 of 1 file). Show all

Unified · Split

libavfilter/avfiltergraph.c+3−1
@@ -29,6 +29,7 @@ · 28 unmodified lines
2929 #include "internal.h"
3030
3131 #include "libavutil/audioconvert.h"
32+#include "libavutil/avassert.h"
3233 #include "libavutil/log.h"
3334
3435 static const AVClass filtergraph_class = {
@@ -497,7 +498,7 @@ static void swap_sample_fmts_on_filter(AVFilterContext *filter) · 462 unmodified lines
497498
498499 for (i = 0; i < filter->nb_outputs; i++) {
499500 AVFilterLink *outlink = filter->outputs[i];
500− int best_idx, best_score = INT_MIN;
501+ int best_idx = -1, best_score = INT_MIN;
501502
502503 if (outlink->type != AVMEDIA_TYPE_AUDIO ||
503504 outlink->in_formats->format_count < 2)
@@ -530,6 +531,7 @@ static void swap_sample_fmts_on_filter(AVFilterContext *filter) · 26 unmodified lines
530531 best_idx = j;
531532 }
532533 }
534+ av_assert0(best_idx >= 0);
533535 FFSWAP(int, outlink->in_formats->formats[0],
534536 outlink->in_formats->formats[best_idx]);
535537 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t