History

vulkan_ffv1: improve buffer barrier correctness for slice state

This is likely a nanooptimization, but its more correct.

Lynne committed 1 year ago

Commit 694ebe81 parent 6111aef1 file · +2 −3Browse files

Unified · Split

libavcodec/vulkan_ffv1.c+2−3
@@ -484,8 +484,7 @@ static int vk_ffv1_end_frame(AVCodecContext *avctx) · 483 unmodified lines
484484 .srcStageMask = slice_state->stage,
485485 .dstStageMask = VK_PIPELINE_STAGE_2_COMPUTE_SHADER_BIT,
486486 .srcAccessMask = slice_state->access,
487− .dstAccessMask = VK_ACCESS_2_SHADER_STORAGE_READ_BIT |
488− VK_ACCESS_2_SHADER_STORAGE_WRITE_BIT,
487+ .dstAccessMask = VK_ACCESS_2_SHADER_STORAGE_READ_BIT,
489488 .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED,
490489 .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED,
491490 .buffer = slice_state->buf,
@@ -534,7 +533,7 @@ static int vk_ffv1_end_frame(AVCodecContext *avctx) · 42 unmodified lines
534533 .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED,
535534 .buffer = slice_state->buf,
536535 .offset = fp->slice_data_size*f->slice_count,
537− .size = slice_state->size - fp->slice_data_size*f->slice_count,
536+ .size = f->slice_count*(fp->slice_state_size - fp->slice_data_size),
538537 };
539538
540539 /* Input frame barrier */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t