History

avformat/mxfdec: Check timecode for overflow

Fixes: signed integer overflow: 9223372036840103968 + 538976288 cannot be represented in type 'long' Fixes: 70604/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-4844090340999168

Michael Niedermayer committed 2 years ago

Commit 6be37861 parent 5a96aa41 file · +3 −0Browse files

Unified · Split

libavformat/mxfdec.c+3−0
@@ -2393,6 +2393,9 @@ static int mxf_parse_physical_source_package(MXFContext *mxf, MXFTrack *source_t · 2392 unmodified lines
23932393 physical_track->edit_rate,
23942394 source_track->edit_rate);
23952395
2396+ if (av_sat_add64(start_position, mxf_tc->start_frame) != start_position + (uint64_t)mxf_tc->start_frame)
2397+ return AVERROR_INVALIDDATA;
2398+
23962399 if (av_timecode_init(&tc, mxf_tc->rate, flags, start_position + mxf_tc->start_frame, mxf->fc) == 0) {
23972400 mxf_add_timecode_metadata(&st->metadata, "timecode", &tc);
23982401 return 0;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t