History

avcodec/cuviddec: improve progressive frame detection

There are 2 types of problems when using adaptive deinterlace with cuvid: 1. Sometimes, in the middle of transcoding, cuvid outputs frames with visible horizontal lines (as though weave deinterlace method was chosen); 2. Occasionally, on scene changes, cuvid outputs a wrong frame, which should have been shown several seconds before (as if the frame was assigned some wrong PTS value). The reason is that sometimes CUVIDPARSERDISPINFO has property progressive_frame equal to 1 with interlaced videos. In order to fix the problem we should check if the video is interlaced or progressive in the beginning of a video sequence (cuvid_handle_video_sequence). And then we just use this information instead of the property progressive_frame in CUVIDPARSERDISPINFO (which is unreliable).

Sergey Svechnikov committed 7 years ago

Commit 703583d1 parent a0877641 file · +6 −0Browse files

Unified · Split

libavcodec/cuviddec.c+6−0
@@ -77,6 +77,7 @@ typedef struct CuvidContext · 76 unmodified lines
7777 int deint_mode;
7878 int deint_mode_current;
7979 int64_t prev_pts;
80+ int progressive_sequence;
8081
8182 int internal_error;
8283 int decoder_flushing;
@@ -216,6 +217,8 @@ static int CUDAAPI cuvid_handle_video_sequence(void *opaque, CUVIDEOFORMAT* form · 133 unmodified lines
216217 ? cudaVideoDeinterlaceMode_Weave
217218 : ctx->deint_mode;
218219
220+ ctx->progressive_sequence = format->progressive_sequence;
221+
219222 if (!format->progressive_sequence && ctx->deint_mode_current == cudaVideoDeinterlaceMode_Weave)
220223 avctx->flags |= AV_CODEC_FLAG_INTERLACED_DCT;
221224 else
@@ -349,6 +352,9 @@ static int CUDAAPI cuvid_handle_picture_display(void *opaque, CUVIDPARSERDISPINF · 127 unmodified lines
349352 parsed_frame.dispinfo = *dispinfo;
350353 ctx->internal_error = 0;
351354
355+ // For some reason, dispinfo->progressive_frame is sometimes wrong.
356+ parsed_frame.dispinfo.progressive_frame = ctx->progressive_sequence;
357+
352358 if (ctx->deint_mode_current == cudaVideoDeinterlaceMode_Weave) {
353359 av_fifo_generic_write(ctx->frame_queue, &parsed_frame, sizeof(CuvidParsedFrame), NULL);
354360 } else {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t