History

avcodec/vvcdec: refact, remove hf_idx and vf_idx from mc_xxx's param list

Nuo Mi committed 2 years ago

Commit 7904ec21 parent 77d971c1 file · +15 −12Browse files

Showing the changes to libavcodec (1 of 1 file). Show all

Unified · Split

libavcodec/vvc/inter.c+15−12
@@ -208,6 +208,7 @@ static void mc(VVCLocalContext *lc, int16_t *dst, const VVCFrame *ref, const Mv · 207 unmodified lines
208208 int x_off, int y_off, const int block_w, const int block_h, const int c_idx)
209209 {
210210 const VVCFrameContext *fc = lc->fc;
211+ const PredictionUnit *pu = &lc->cu->pu;
211212 const uint8_t *src = ref->frame->data[c_idx];
212213 ptrdiff_t src_stride = ref->frame->linesize[c_idx];
213214 const int is_chroma = !!c_idx;
@@ -216,8 +217,9 @@ static void mc(VVCLocalContext *lc, int16_t *dst, const VVCFrame *ref, const Mv · 2 unmodified lines
216217 const int idx = av_log2(block_w) - 1;
217218 const intptr_t mx = av_mod_uintp2(mv->x, 4 + hs) << (is_chroma - hs);
218219 const intptr_t my = av_mod_uintp2(mv->y, 4 + vs) << (is_chroma - vs);
219− const int8_t *hf = INTER_FILTER(0, mx);
220− const int8_t *vf = INTER_FILTER(0, my);
220+ const int hpel_if_idx = (is_chroma || pu->merge_gpm_flag) ? 0 : pu->mi.hpel_if_idx;
221+ const int8_t *hf = INTER_FILTER(hpel_if_idx, mx);
222+ const int8_t *vf = INTER_FILTER(hpel_if_idx, my);
221223
222224 x_off += mv->x >> (4 + hs);
223225 y_off += mv->y >> (4 + vs);
@@ -229,9 +231,10 @@ static void mc(VVCLocalContext *lc, int16_t *dst, const VVCFrame *ref, const Mv · 5 unmodified lines
229231
230232 static void mc_uni(VVCLocalContext *lc, uint8_t *dst, const ptrdiff_t dst_stride,
231233 const VVCFrame *ref, const MvField *mvf, int x_off, int y_off, const int block_w, const int block_h,
232− const int c_idx, const int hf_idx, const int vf_idx)
234+ const int c_idx)
233235 {
234236 const VVCFrameContext *fc = lc->fc;
237+ const PredictionUnit *pu = &lc->cu->pu;
235238 const uint8_t *src = ref->frame->data[c_idx];
236239 ptrdiff_t src_stride = ref->frame->linesize[c_idx];
237240 const int lx = mvf->pred_flag - PF_L0;
@@ -242,8 +245,9 @@ static void mc_uni(VVCLocalContext *lc, uint8_t *dst, const ptrdiff_t dst_stride · 4 unmodified lines
242245 const int is_chroma = !!c_idx;
243246 const intptr_t mx = av_mod_uintp2(mv->x, 4 + hs) << (is_chroma - hs);
244247 const intptr_t my = av_mod_uintp2(mv->y, 4 + vs) << (is_chroma - vs);
245− const int8_t *hf = INTER_FILTER(hf_idx, mx);
246− const int8_t *vf = INTER_FILTER(vf_idx, my);
248+ const int hpel_if_idx = is_chroma ? 0 : pu->mi.hpel_if_idx;
249+ const int8_t *hf = INTER_FILTER(hpel_if_idx, mx);
250+ const int8_t *vf = INTER_FILTER(hpel_if_idx, my);
247251 int denom, wx, ox;
248252
249253 x_off += mv->x >> (4 + hs);
@@ -263,7 +267,7 @@ static void mc_uni(VVCLocalContext *lc, uint8_t *dst, const ptrdiff_t dst_stride · 13 unmodified lines
263267 static void mc_bi(VVCLocalContext *lc, uint8_t *dst, const ptrdiff_t dst_stride,
264268 const VVCFrame *ref0, const VVCFrame *ref1, const MvField *mvf, const MvField *orig_mv,
265269 const int x_off, const int y_off, const int block_w, const int block_h, const int c_idx,
266− const int sb_bdof_flag, const int hf_idx, const int vf_idx)
270+ const int sb_bdof_flag)
267271 {
268272 const VVCFrameContext *fc = lc->fc;
269273 const PredictionUnit *pu = &lc->cu->pu;
@@ -275,6 +279,7 @@ static void mc_bi(VVCLocalContext *lc, uint8_t *dst, const ptrdiff_t dst_stride, · 5 unmodified lines
275279 int denom, w0, w1, o0, o1;
276280 const int weight_flag = derive_weight(&denom, &w0, &w1, &o0, &o1, lc, mvf, c_idx, pu->dmvr_flag);
277281 const int is_chroma = !!c_idx;
282+ const int hpel_if_idx = is_chroma ? 0 : pu->mi.hpel_if_idx;
278283
279284 for (int i = L0; i <= L1; i++) {
280285 const Mv *mv = mvf->mv + i;
@@ -285,8 +290,8 @@ static void mc_bi(VVCLocalContext *lc, uint8_t *dst, const ptrdiff_t dst_stride, · 4 unmodified lines
285290 const VVCFrame *ref = refs[i];
286291 ptrdiff_t src_stride = ref->frame->linesize[c_idx];
287292 const uint8_t *src = ref->frame->data[c_idx] + oy * src_stride + (ox * (1 << fc->ps.sps->pixel_shift));
288− const int8_t *hf = INTER_FILTER(hf_idx, mx);
289− const int8_t *vf = INTER_FILTER(vf_idx, my);
293+ const int8_t *hf = INTER_FILTER(hpel_if_idx, mx);
294+ const int8_t *vf = INTER_FILTER(hpel_if_idx, my);
290295
291296 if (pu->dmvr_flag) {
292297 const int x_sb = x_off + (orig_mv->mv[i].x >> (4 + hs));
@@ -515,17 +520,15 @@ static void pred_regular(VVCLocalContext *lc, const MvField *mvf, const MvField · 222 unmodified lines
515520 const int do_ciip = lc->cu->ciip_flag && (is_luma || (w > 2));
516521 uint8_t *inter = do_ciip ? (uint8_t *)lc->ciip_tmp : dst;
517522 const ptrdiff_t inter_stride = do_ciip ? (MAX_PB_SIZE * sizeof(uint16_t)) : dst_stride;
518− const int hf_idx = is_luma ? lc->cu->pu.mi.hpel_if_idx : 0;
519− const int vf_idx = is_luma ? lc->cu->pu.mi.hpel_if_idx : 0;
520523 const int do_bdof = is_luma && sb_bdof_flag;
521524
522525 if (mvf->pred_flag != PF_BI) {
523526 const int lx = mvf->pred_flag - PF_L0;
524527 mc_uni(lc, inter, inter_stride, refp[lx]->ref, mvf,
525− x, y, w, h, c_idx, hf_idx, vf_idx);
528+ x, y, w, h, c_idx);
526529 } else {
527530 mc_bi(lc, inter, inter_stride, refp[L0]->ref, refp[L1]->ref, mvf, orig_mvf,
528− x, y, w, h, c_idx, do_bdof, hf_idx, vf_idx);
531+ x, y, w, h, c_idx, do_bdof);
529532 }
530533 if (do_ciip) {
531534 const int intra_weight = ciip_derive_intra_weight(lc, x0, y0, sbw, sbh);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t