History

avfilter/vf_coreimage: simplify list_filters code

Use fast-enumeration and get rid of unnecessary intermediate variables.

Marvin Scholz committed 2 years ago

Commit 799503f1 parent 8d674e61 file · +4 −10Browse files

Showing the changes to libavfilter (1 of 1 file). Show all

Unified · Split

libavfilter/vf_coreimage.m+4−10
@@ -102,19 +102,13 @@ static void list_filters(CoreImageContext *ctx) · 101 unmodified lines
102 filter_categories = [NSArray arrayWithObjects:kCICategoryGenerator, nil];102 filter_categories = [NSArray arrayWithObjects:kCICategoryGenerator, nil];
103 }103 }
104 104
105 NSArray *filter_names = [CIFilter filterNamesInCategories:filter_categories];105 for (NSString *filter_name in [CIFilter filterNamesInCategories:filter_categories]) {
106 NSEnumerator *filters = [filter_names objectEnumerator];106 CIFilter *filter = [CIFilter filterWithName:filter_name];
107 NSDictionary<NSString *, id> *filter_attribs = [filter attributes];
107 108
108 NSString *filter_name;
109 while (filter_name = [filters nextObject]) {
110 av_log(ctx, AV_LOG_INFO, "Filter: %s\n", [filter_name UTF8String]);109 av_log(ctx, AV_LOG_INFO, "Filter: %s\n", [filter_name UTF8String]);
111 NSString *input;
112 110
113 CIFilter *filter = [CIFilter filterWithName:filter_name];111 for (NSString *input in [filter inputKeys]) {
114 NSDictionary *filter_attribs = [filter attributes]; // <nsstring, id>
115 NSArray *filter_inputs = [filter inputKeys]; // <nsstring>
116
117 for (input in filter_inputs) {
118 NSDictionary *input_attribs = [filter_attribs valueForKey:input];112 NSDictionary *input_attribs = [filter_attribs valueForKey:input];
119 NSString *input_class = [input_attribs valueForKey:kCIAttributeClass];113 NSString *input_class = [input_attribs valueForKey:kCIAttributeClass];
120 if ([input_class isEqualToString:@"NSNumber"]) {114 if ([input_class isEqualToString:@"NSNumber"]) {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t