When the headphone filter does its processing in the time domain, the lengths of the buffers involved are determined by three parameters, only two of which are relevant here: ir_len and air_len. The former is the length (in samples) of the longest HRIR input stream and the latter is the smallest power-of-two bigger than ir_len. Using optimized functions to calculate the convolution places restrictions on the alignment of the length of the vectors whose scalar product is calculated. Therefore said length, namely ir_len, is aligned on 32; but the number of elements of the buffers used is given by air_len and for ir_len < 16 a buffer overflow happens. This commit fixes this by ensuring that air_len is always >= 32 if processing happens in the time domain.
Showing the changes to libavfilter (1 of 1 file). Show all
Unified · Split
| @@ -405,6 +405,9 @@ static int convert_coeffs(AVFilterContext *ctx, AVFilterLink *inlink) · 404 unmodified lines | |||
| 405 | int i, j, k; | 405 | int i, j, k; |
| 406 | 406 | ||
| 407 | s->air_len = 1 << (32 - ff_clz(ir_len)); | 407 | s->air_len = 1 << (32 - ff_clz(ir_len)); |
| 408 | if (s->type == TIME_DOMAIN) { | ||
| 409 | s->air_len = FFALIGN(s->air_len, 32); | ||
| 410 | } | ||
| 408 | s->buffer_length = 1 << (32 - ff_clz(s->air_len)); | 411 | s->buffer_length = 1 << (32 - ff_clz(s->air_len)); |
| 409 | s->n_fft = n_fft = 1 << (32 - ff_clz(ir_len + s->size)); | 412 | s->n_fft = n_fft = 1 << (32 - ff_clz(ir_len + s->size)); |
| 410 | 413 | ||