History

avfilter/af_aiir: reverse order of biquads in serial processing

This avoids most of clippings for fixed-point precision inputs. Also add warning about filtering fixed-point precision with parallel processing.

Paul B Mahol committed 6 years ago

Commit 7c1eef41 parent 33624f41 file · +3 −1Browse files

Unified · Split

libavfilter/af_aiir.c+3−1
@@ -195,7 +195,7 @@ static int iir_ch_serial_## name(AVFilterContext *ctx, void *arg, \ · 194 unmodified lines
195 int nb_biquads = (FFMAX(iir->nb_ab[0], iir->nb_ab[1]) + 1) / 2; \195 int nb_biquads = (FFMAX(iir->nb_ab[0], iir->nb_ab[1]) + 1) / 2; \
196 int n, i; \196 int n, i; \
197 \197 \
198 for (i = 0; i < nb_biquads; i++) { \198 for (i = nb_biquads - 1; i >= 0; i--) { \
199 const double a1 = -iir->biquads[i].a[1]; \199 const double a1 = -iir->biquads[i].a[1]; \
200 const double a2 = -iir->biquads[i].a[2]; \200 const double a2 = -iir->biquads[i].a[2]; \
201 const double b0 = iir->biquads[i].b[0]; \201 const double b0 = iir->biquads[i].b[0]; \
@@ -1226,6 +1226,8 @@ static int config_output(AVFilterLink *outlink) · 1024 unmodified lines
1226 if (ret < 0)1226 if (ret < 0)
1227 return ret;1227 return ret;
1228 } else if (s->format > 0 && s->process == 2) {1228 } else if (s->format > 0 && s->process == 2) {
1229 if (s->precision > 1)
1230 av_log(ctx, AV_LOG_WARNING, "Parallel processing is not recommended for fixed-point precisions.\n");
1229 ret = decompose_zp2biquads(ctx, inlink->channels);1231 ret = decompose_zp2biquads(ctx, inlink->channels);
1230 if (ret < 0)1232 if (ret < 0)
1231 return ret;1233 return ret;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t