History

avcodec/apv_decode: make apv_format_table consistent with the code and check it

Fixes: writing in a null pointer Fixes: 435278398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APV_fuzzer-4566392923029504

Michael Niedermayer committed 1 year ago

Commit 7c92f741 parent 057b9461 file · +8 −3Browse files

Unified · Split

libavcodec/apv_decode.c+8−3
@@ -52,9 +52,9 @@ typedef struct APVDecodeContext { · 51 unmodified lines
5252 static const enum AVPixelFormat apv_format_table[5][5] = {
5353 { AV_PIX_FMT_GRAY8, AV_PIX_FMT_GRAY10, AV_PIX_FMT_GRAY12, AV_PIX_FMT_GRAY14, AV_PIX_FMT_GRAY16 },
5454 { 0 }, // 4:2:0 is not valid.
55− { AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV422P10, AV_PIX_FMT_YUV422P12, AV_PIX_FMT_GRAY14, AV_PIX_FMT_YUV422P16 },
56− { AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV444P10, AV_PIX_FMT_YUV444P12, AV_PIX_FMT_GRAY14, AV_PIX_FMT_YUV444P16 },
57− { AV_PIX_FMT_YUVA444P, AV_PIX_FMT_YUVA444P10, AV_PIX_FMT_YUVA444P12, AV_PIX_FMT_GRAY14, AV_PIX_FMT_YUVA444P16 },
55+ { AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV422P10, AV_PIX_FMT_YUV422P12, AV_PIX_FMT_YUV422P14, AV_PIX_FMT_YUV422P16 },
56+ { AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV444P10, AV_PIX_FMT_YUV444P12, AV_PIX_FMT_YUV444P14, AV_PIX_FMT_YUV444P16 },
57+ { AV_PIX_FMT_YUVA444P, AV_PIX_FMT_YUVA444P10, AV_PIX_FMT_YUVA444P12, 0 ,AV_PIX_FMT_YUVA444P16 },
5858 };
5959
6060 static APVVLCLUT decode_lut;
@@ -75,6 +75,11 @@ static int apv_decode_check_format(AVCodecContext *avctx, · 14 unmodified lines
7575 avctx->pix_fmt =
7676 apv_format_table[header->frame_info.chroma_format_idc][bit_depth - 4 >> 2];
7777
78+ if (!avctx->pix_fmt) {
79+ avpriv_request_sample(avctx, "YUVA444P14");
80+ return AVERROR_PATCHWELCOME;
81+ }
82+
7883 err = ff_set_dimensions(avctx,
7984 FFALIGN(header->frame_info.frame_width, 16),
8085 FFALIGN(header->frame_info.frame_height, 16));

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t