History

avformat/mov: make sure file_checksum is fully initialized

Fixes: use of uninitialized memory Fixes: 394990189/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6431722199908352

Michael Niedermayer committed 1 year ago

Commit 8b16e1d1 parent 7a21c371 file · +3 −1Browse files

Unified · Split

libavformat/mov.c+3−1
@@ -1407,7 +1407,9 @@ static int mov_read_adrm(MOVContext *c, AVIOContext *pb, MOVAtom atom) · 1406 unmodified lines
14071407 avio_read(pb, output, 8); // go to offset 8, absolute position 0x251
14081408 avio_read(pb, input, DRM_BLOB_SIZE);
14091409 avio_read(pb, output, 4); // go to offset 4, absolute position 0x28d
1410− avio_read(pb, file_checksum, 20);
1410+ ret = ffio_read_size(pb, file_checksum, 20);
1411+ if (ret < 0)
1412+ goto fail;
14111413
14121414 // required by external tools
14131415 ff_data_to_hex(checksum_string, file_checksum, sizeof(file_checksum), 1);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t