History

configure: fix symbol prefix detection

The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to only detect a one-character prefix, which is the only case that matters anywhere right now.

Marvin Scholz committed 2 years ago

Commit 910bf331 parent 0c9fe2b1 file · +3 −1Browse files

Unified · Split

configure+3−1
@@ -6137,9 +6137,11 @@ enabled pic && enable_weak_pic · 6136 unmodified lines
6137test_cc <<EOF || die "Symbol mangling check failed."6137test_cc <<EOF || die "Symbol mangling check failed."
6138int ff_extern;6138int ff_extern;
6139EOF6139EOF
6140sym=$($nm $TMPO | awk '/ff_extern/{ print substr($0, match($0, /[^ \t]*ff_extern/)) }')6140sym=$($nm $TMPO | awk '/[ \t]+[^ \t]{0,1}ff_extern$/{ print substr($0, match($0, /[^ \t]{0,1}ff_extern$/)) }')
6141extern_prefix=${sym%%ff_extern*}6141extern_prefix=${sym%%ff_extern*}
6142 6142
6143log "Symbol prefix detected as: '${extern_prefix}'"
6144
6143! disabled inline_asm && check_inline_asm inline_asm '"" ::'6145! disabled inline_asm && check_inline_asm inline_asm '"" ::'
6144 6146
6145check_cc pragma_deprecated "" '_Pragma("GCC diagnostic push") _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")'6147check_cc pragma_deprecated "" '_Pragma("GCC diagnostic push") _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")'

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t