History

vulkan_encode_h264: fix rate control VBV values

The values must be in milliseconds, not bytes.

Lynne committed 2 years ago

Commit 934be0f1 parent fd1ea751 file · +3 −3Browse files

Unified · Split

libavcodec/vulkan_encode_h264.c+3−3
@@ -130,12 +130,12 @@ static int init_pic_rc(AVCodecContext *avctx, FFHWBaseEncodePicture *pic, · 129 unmodified lines
130130 .consecutiveBFrameCount = FFMAX(ctx->base.b_per_p - 1, 0),
131131 .temporalLayerCount = 0,
132132 };
133−
134133 rc_info->pNext = &hp->vkrc_info;
135− rc_info->virtualBufferSizeInMs = enc->unit_opts.hrd_buffer_size;
136− rc_info->initialVirtualBufferSizeInMs = enc->unit_opts.initial_buffer_fullness;
137134
138135 if (rc_info->rateControlMode > VK_VIDEO_ENCODE_RATE_CONTROL_MODE_DISABLED_BIT_KHR) {
136+ rc_info->virtualBufferSizeInMs = (enc->unit_opts.hrd_buffer_size * 1000LL) / avctx->bit_rate;
137+ rc_info->initialVirtualBufferSizeInMs = (enc->unit_opts.initial_buffer_fullness * 1000LL) / avctx->bit_rate;
138+
139139 hp->vkrc_layer_info = (VkVideoEncodeH264RateControlLayerInfoKHR) {
140140 .sType = VK_STRUCTURE_TYPE_VIDEO_ENCODE_H264_RATE_CONTROL_LAYER_INFO_KHR,
141141

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t