Unified · Split
| @@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just · 418 unmodified lines | |||
| 419 | the result of a series of patches. So if you have a series of commits | 419 | the result of a series of patches. So if you have a series of commits |
| 420 | to push, run the test suite on every single commit. | 420 | to push, run the test suite on every single commit. |
| 421 | 421 | ||
| 422 | Give other developers a reasonable amount of time to look at and review | ||
| 423 | patches before you push them. Not everybody is online 24/7, but may wish | ||
| 424 | to look at and comment on a patch nonetheless. The time you leave depends | ||
| 425 | on the urgency and complexity of the patch. Use your common sense to pick | ||
| 426 | a timeframe that allows everybody that you think may wish to comment | ||
| 427 | and/or should comment on the change an opportunity to see it. | ||
| 428 | |||
| 422 | Finally, after pushing, mark all patches as committed on | 429 | Finally, after pushing, mark all patches as committed on |
| 423 | @url{http://patches.libav.org/,patchwork}. | 430 | @url{http://patches.libav.org/,patchwork}. |
| 424 | Sometimes this is not automatically done when a patch has been | 431 | Sometimes this is not automatically done when a patch has been |