vaapi_encode: Do not zero access unit structures

Following b8c45bbcbc207293f955e838ea66106f4b65b1ac they contain allocated unit arrays which will get leaked. These operations were inconsistently applied and never actually needed (the old uninit left them in the correct state), so just drop them entirely.

Mark Thompson committed 7 years ago

Commit 9d5ca711 parent b8c45bb2 files · +0 −9Browse files

Unified · Split

2 files

libavcodec/vaapi_encode_h264.c +0 −6
libavcodec/vaapi_encode_h265.c +0 −3

libavcodec/vaapi_encode_h264.c+0−6

     VAEncSequenceParameterBufferH264 *vseq = ctx->codec_sequence_params;
     VAEncPictureParameterBufferH264  *vpic = ctx->codec_picture_params;
-    memset(&priv->current_access_unit, 0,
-           sizeof(priv->current_access_unit));
     memset(sps, 0, sizeof(*sps));
     memset(pps, 0, sizeof(*pps));
     VAEncPictureParameterBufferH264 *vpic = pic->codec_picture_params;
     int i;
-    memset(&priv->current_access_unit, 0,
-           sizeof(priv->current_access_unit));
     if (pic->type == PICTURE_TYPE_IDR) {
         av_assert0(pic->display_order == pic->encode_order);

libavcodec/vaapi_encode_h265.c+0−3

@@ -270,9 +270,6 @@ static int vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) · 269 unmodified lines
270	int chroma_format, bit_depth;	270	int chroma_format, bit_depth;
271	int i;	271	int i;
272		272
273	memset(&priv->current_access_unit, 0,
274	sizeof(priv->current_access_unit));
275
276	memset(vps, 0, sizeof(*vps));	273	memset(vps, 0, sizeof(*vps));
277	memset(sps, 0, sizeof(*sps));	274	memset(sps, 0, sizeof(*sps));
278	memset(pps, 0, sizeof(*pps));	275	memset(pps, 0, sizeof(*pps));

vaapi_encode: Do not zero access unit structures

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code