ogg_save() copies streams[], but doesn't keep track of free()'ed struct members. Thus, if in between a call to ogg_save() and ogg_restore(), streams[].private was free()'ed, this would result in a double free -> crash, which happened when e.g. playing small chained ogg fragments.
Unified · Split
| @@ -238,7 +238,8 @@ static int ogg_read_page(AVFormatContext *s, int *str) · 237 unmodified lines | |||
| 238 | 238 | ||
| 239 | for (n = 0; n < ogg->nstreams; n++) { | 239 | for (n = 0; n < ogg->nstreams; n++) { |
| 240 | av_freep(&ogg->streams[n].buf); | 240 | av_freep(&ogg->streams[n].buf); |
| 241 | av_freep(&ogg->streams[n].private); | 241 | if (!ogg->state || ogg->state->streams[n].private != ogg->streams[n].private) |
| 242 | av_freep(&ogg->streams[n].private); | ||
| 242 | } | 243 | } |
| 243 | ogg->curidx = -1; | 244 | ogg->curidx = -1; |
| 244 | ogg->nstreams = 0; | 245 | ogg->nstreams = 0; |