History

lavc/dxv: assume DXV2 files use premultiplied alpha

I generated a DXV2 file with an interesting alpha channel using Adobe Media Encoder 2015 and compared decoding it using Resolume Alley and ffmpeg. Similarly to DXV3 files, Alley expects premultiplied alpha and ffmpeg matches its decoding more closely when it does the same. Reference file: https://connorworley.com/dxv2-dxt5.mov Existing FATE tests for DXV2 files do not cover this change.

Connor Worley committed 2 years ago

Commit a4f019e1 parent 1487f611 file · +1 −1Browse files

Showing the changes to libavcodec (1 of 1 file). Show all

Unified · Split

libavcodec/dxv.c+1−1
@@ -919,7 +919,7 @@ static int dxv_decode(AVCodecContext *avctx, AVFrame *frame, · 918 unmodified lines
919919 tag = DXV_FMT_DXT5;
920920 msgtext = "DXT5";
921921
922− texdsp_ctx.tex_funct = ctx->texdsp.dxt5_block;
922+ texdsp_ctx.tex_funct = ctx->texdsp.dxt4_block;
923923 texdsp_ctx.tex_ratio = 16;
924924 texdsp_ctx.raw_ratio = 16;
925925 } else if (old_type & 0x20 || version_major == 1) {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t