History

avfilter/af_biquads: always return same number of samples with block processing

Paul B Mahol committed 4 years ago

Commit b5aa5141 parent 30e2bb01 file · +56 −12Browse files

Showing the changes to libavfilter (1 of 1 file). Show all

Unified · Split

libavfilter/af_biquads.c+56−12
@@ -149,6 +149,9 @@ typedef struct BiquadsContext { · 148 unmodified lines
149149 ChanCache *cache;
150150 int block_align;
151151
152+ int64_t pts;
153+ int nb_samples;
154+
152155 void (*filter)(struct BiquadsContext *s, const void *ibuf, void *obuf, int len,
153156 double *i1, double *i2, double *o1, double *o2,
154157 double b0, double b1, double b2, double a0, double a1, double a2, int *clippings,
@@ -995,7 +998,6 @@ static int config_filter(AVFilterLink *outlink, int reset) · 840 unmodified lines
995998 return AVERROR(ENOMEM);
996999 av_samples_set_silence(s->block[i]->extended_data, 0, s->block_samples * 2,
9971000 s->block[i]->ch_layout.nb_channels, s->block[i]->format);
998−
9991001 }
10001002 }
10011003
@@ -1142,6 +1144,7 @@ static int config_output(AVFilterLink *outlink) · 140 unmodified lines
11421144
11431145 typedef struct ThreadData {
11441146 AVFrame *in, *out;
1147+ int eof;
11451148 } ThreadData;
11461149
11471150 static void reverse_samples(AVFrame *out, AVFrame *in, int p,
@@ -1194,7 +1197,6 @@ static int filter_channel(AVFilterContext *ctx, void *arg, int jobnr, int nb_job · 46 unmodified lines
11941197 enum AVChannel channel = av_channel_layout_channel_from_index(&inlink->ch_layout, ch);
11951198
11961199 if (av_channel_layout_index_from_channel(&s->ch_layout, channel) < 0) {
1197−
11981200 if (buf != out_buf)
11991201 memcpy(out_buf->extended_data[ch], buf->extended_data[ch],
12001202 buf->nb_samples * s->block_align);
@@ -1205,9 +1207,14 @@ static int filter_channel(AVFilterContext *ctx, void *arg, int jobnr, int nb_job · 4 unmodified lines
12051207 s->filter(s, buf->extended_data[ch], out_buf->extended_data[ch], buf->nb_samples,
12061208 &s->cache[ch].i1, &s->cache[ch].i2, &s->cache[ch].o1, &s->cache[ch].o2,
12071209 s->b0, s->b1, s->b2, s->a0, s->a1, s->a2, &s->cache[ch].clippings, ctx->is_disabled);
1210+ } else if (td->eof) {
1211+ memcpy(out_buf->extended_data[ch], s->block[1]->extended_data[ch] + s->block_align * s->block_samples,
1212+ s->nb_samples * s->block_align);
12081213 } else {
12091214 memcpy(s->block[0]->extended_data[ch] + s->block_align * s->block_samples, buf->extended_data[ch],
12101215 buf->nb_samples * s->block_align);
1216+ memset(s->block[0]->extended_data[ch] + s->block_align * (s->block_samples + buf->nb_samples),
1217+ 0, (s->block_samples - buf->nb_samples) * s->block_align);
12111218 s->filter(s, s->block[0]->extended_data[ch], s->block[1]->extended_data[ch], s->block_samples,
12121219 &s->cache[ch].i1, &s->cache[ch].i2, &s->cache[ch].o1, &s->cache[ch].o2,
12131220 s->b0, s->b1, s->b2, s->a0, s->a1, s->a2, &s->cache[ch].clippings, ctx->is_disabled);
@@ -1220,15 +1227,17 @@ static int filter_channel(AVFilterContext *ctx, void *arg, int jobnr, int nb_job · 6 unmodified lines
12201227 s->block_samples,
12211228 &s->cache[ch].ri1, &s->cache[ch].ri2, &s->cache[ch].ro1, &s->cache[ch].ro2,
12221229 s->b0, s->b1, s->b2, s->a0, s->a1, s->a2, &s->cache[ch].clippings, ctx->is_disabled);
1223− reverse_samples(s->block[2], s->block[1], ch, 0, 0, s->block_samples * 2);
1230+ reverse_samples(s->block[2], s->block[1], ch, 0, 0, 2 * s->block_samples);
12241231 s->cache[ch].ri1 = 0.;
12251232 s->cache[ch].ri2 = 0.;
12261233 s->cache[ch].ro1 = 0.;
12271234 s->cache[ch].ro2 = 0.;
1228− s->filter(s, s->block[2]->extended_data[ch], s->block[2]->extended_data[ch], s->block[2]->nb_samples,
1235+ s->filter(s, s->block[2]->extended_data[ch], s->block[2]->extended_data[ch], 2 * s->block_samples,
12291236 &s->cache[ch].ri1, &s->cache[ch].ri2, &s->cache[ch].ro1, &s->cache[ch].ro2,
12301237 s->b0, s->b1, s->b2, s->a0, s->a1, s->a2, &s->cache[ch].clippings, ctx->is_disabled);
1231− reverse_samples(out_buf, s->block[2], ch, 0, s->block_samples, out_buf->nb_samples);
1238+ reverse_samples(s->block[1], s->block[2], ch, 0, 0, 2 * s->block_samples);
1239+ memcpy(out_buf->extended_data[ch], s->block[1]->extended_data[ch],
1240+ s->block_samples * s->block_align);
12321241 memmove(s->block[0]->extended_data[ch], s->block[0]->extended_data[ch] + s->block_align * s->block_samples,
12331242 s->block_samples * s->block_align);
12341243 }
@@ -1237,14 +1246,14 @@ static int filter_channel(AVFilterContext *ctx, void *arg, int jobnr, int nb_job · 2 unmodified lines
12371246 return 0;
12381247 }
12391248
1240−static int filter_frame(AVFilterLink *inlink, AVFrame *buf)
1249+static int filter_frame(AVFilterLink *inlink, AVFrame *buf, int eof)
12411250 {
12421251 AVFilterContext *ctx = inlink->dst;
12431252 BiquadsContext *s = ctx->priv;
12441253 AVFilterLink *outlink = ctx->outputs[0];
12451254 AVFrame *out_buf;
12461255 ThreadData td;
1247− int ch, ret;
1256+ int ch, ret, drop = 0;
12481257
12491258 if (s->bypass)
12501259 return ff_filter_frame(outlink, buf);
@@ -1258,10 +1267,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *buf) · 7 unmodified lines
12581267 av_channel_layout_from_string(&s->ch_layout,
12591268 s->ch_layout_str);
12601269
1261− if (av_frame_is_writable(buf)) {
1270+ if (av_frame_is_writable(buf) && s->block_samples == 0) {
12621271 out_buf = buf;
12631272 } else {
1264− out_buf = ff_get_audio_buffer(outlink, buf->nb_samples);
1273+ out_buf = ff_get_audio_buffer(outlink, s->block_samples > 0 ? s->block_samples : buf->nb_samples);
12651274 if (!out_buf) {
12661275 av_frame_free(&buf);
12671276 return AVERROR(ENOMEM);
@@ -1269,8 +1278,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *buf) · 1 unmodified line
12691278 av_frame_copy_props(out_buf, buf);
12701279 }
12711280
1281+ if (s->block_samples > 0 && s->pts == AV_NOPTS_VALUE)
1282+ drop = 1;
12721283 td.in = buf;
12731284 td.out = out_buf;
1285+ td.eof = eof;
12741286 ff_filter_execute(ctx, filter_channel, &td, NULL,
12751287 FFMIN(outlink->ch_layout.nb_channels, ff_filter_get_nb_threads(ctx)));
12761288
@@ -1281,10 +1293,26 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *buf) · 4 unmodified lines
12811293 s->cache[ch].clippings = 0;
12821294 }
12831295
1296+ if (s->block_samples > 0) {
1297+ int nb_samples = buf->nb_samples;
1298+ int64_t pts = buf->pts;
1299+
1300+ out_buf->pts = s->pts;
1301+ out_buf->nb_samples = s->nb_samples;
1302+ s->pts = pts;
1303+ s->nb_samples = nb_samples;
1304+ }
1305+
12841306 if (buf != out_buf)
12851307 av_frame_free(&buf);
12861308
1287− return ff_filter_frame(outlink, out_buf);
1309+ if (!drop)
1310+ return ff_filter_frame(outlink, out_buf);
1311+ else {
1312+ av_frame_free(&out_buf);
1313+ ff_filter_set_ready(ctx, 10);
1314+ return 0;
1315+ }
12881316 }
12891317
12901318 static int activate(AVFilterContext *ctx)
@@ -1293,6 +1321,8 @@ static int activate(AVFilterContext *ctx) · 2 unmodified lines
12931321 AVFilterLink *outlink = ctx->outputs[0];
12941322 BiquadsContext *s = ctx->priv;
12951323 AVFrame *in = NULL;
1324+ int64_t pts;
1325+ int status;
12961326 int ret;
12971327
12981328 FF_FILTER_FORWARD_STATUS_BACK(outlink, inlink);
@@ -1305,14 +1335,27 @@ static int activate(AVFilterContext *ctx) · 6 unmodified lines
13051335 if (ret < 0)
13061336 return ret;
13071337 if (ret > 0)
1308− return filter_frame(inlink, in);
1338+ return filter_frame(inlink, in, 0);
13091339
13101340 if (s->block_samples > 0 && ff_inlink_queued_samples(inlink) >= s->block_samples) {
13111341 ff_filter_set_ready(ctx, 10);
13121342 return 0;
13131343 }
13141344
1315− FF_FILTER_FORWARD_STATUS(inlink, outlink);
1345+ if (ff_inlink_acknowledge_status(inlink, &status, &pts)) {
1346+ if (s->block_samples > 0) {
1347+ AVFrame *in = ff_get_audio_buffer(outlink, s->block_samples);
1348+ if (!in)
1349+ return AVERROR(ENOMEM);
1350+
1351+ ret = filter_frame(inlink, in, 1);
1352+ }
1353+
1354+ ff_outlink_set_status(outlink, status, pts);
1355+
1356+ return ret;
1357+ }
1358+
13161359 FF_FILTER_FORWARD_WANTED(outlink, inlink);
13171360
13181361 return FFERROR_NOT_READY;
@@ -1365,6 +1408,7 @@ static av_cold int name_##_init(AVFilterContext *ctx) \ · 46 unmodified lines
13651408 { \
13661409 BiquadsContext *s = ctx->priv; \
13671410 s->filter_type = name_; \
1411+ s->pts = AV_NOPTS_VALUE; \
13681412 return 0; \
13691413 } \
13701414 \

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t