avcodec/h261enc: Make h261_encode_init() call ff_mpv_encode_init()

Right now, ff_mpv_encode_init() is set as FFCodec.init and calls ff_h261_encode_init(). The opposite is more natural and avoids a non-static function.

Andreas Rheinhardt committed 1 year ago

Commit b7ee7991 parent 3275d783 files · +9 −14Browse files

Unified · Split

3 files

libavcodec/h261enc.c +9 −8
libavcodec/h261enc.h +0 −1
libavcodec/mpegvideo_enc.c +0 −5

libavcodec/h261enc.c+9−8

     mv_codes[0][1] = 1;
 }
-av_cold int ff_h261_encode_init(MpegEncContext *s)
+static av_cold int h261_encode_init(AVCodecContext *avctx)
 {
-    H261EncContext *const h = (H261EncContext*)s;
     static AVOnce init_static_once = AV_ONCE_INIT;
+    H261EncContext *const h = avctx->priv_data;
+    MpegEncContext *const s = &h->s.s;
-    if (s->width == 176 && s->height == 144) {
+    if (avctx->width == 176 && avctx->height == 144) {
         h->format = H261_QCIF;
-    } else if (s->width == 352 && s->height == 288) {
+    } else if (avctx->width == 352 && avctx->height == 288) {
         h->format = H261_CIF;
     } else {
-        av_log(s->avctx, AV_LOG_ERROR,
+        av_log(avctx, AV_LOG_ERROR,
                 "The specified picture size of %dx%d is not valid for the "
                 "H.261 codec.\nValid sizes are 176x144, 352x288\n",
-                s->width, s->height);
+               avctx->width, avctx->height);
         return AVERROR(EINVAL);
     }
     s->private_ctx = &h->common;
     s->intra_ac_vlc_last_length = s->inter_ac_vlc_last_length = uni_h261_rl_len_last;
     ff_thread_once(&init_static_once, h261_encode_init_static);
-    return 0;
+    return ff_mpv_encode_init(avctx);
 }
 const FFCodec ff_h261_encoder = {
     .p.priv_class   = &ff_mpv_enc_class,
     .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE,
     .priv_data_size = sizeof(H261EncContext),
-    .init           = ff_mpv_encode_init,
+    .init           = h261_encode_init,
     FF_CODEC_ENCODE_CB(ff_mpv_encode_picture),
     .close          = ff_mpv_encode_end,
     .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,

libavcodec/h261enc.h+0−1

@@ -34,6 +34,5 @@ void ff_h261_reorder_mb_index(MpegEncContext *s); · 33 unmodified lines
34	void ff_h261_encode_mb(MpegEncContext *s, int16_t block[6][64],	34	void ff_h261_encode_mb(MpegEncContext *s, int16_t block[6][64],
35	int motion_x, int motion_y);	35	int motion_x, int motion_y);
36	void ff_h261_encode_picture_header(MpegEncContext *s);	36	void ff_h261_encode_picture_header(MpegEncContext *s);
37	int ff_h261_encode_init(MpegEncContext *s);
38		37
39	#endif	38	#endif

libavcodec/mpegvideo_enc.c+0−5

         s->low_delay = 1;
         break;
     case AV_CODEC_ID_H261:
-        if (!CONFIG_H261_ENCODER)
-            return AVERROR_ENCODER_NOT_FOUND;
-        ret = ff_h261_encode_init(s);
-        if (ret < 0)
-            return ret;
         s->out_format = FMT_H261;
         avctx->delay  = 0;
         s->low_delay  = 1;

avcodec/h261enc: Make h261_encode_init() call ff_mpv_encode_init()

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code