History

avformat/matroskadec: Fix seeking

matroska_reset_status (a function that is used during seeking (among other things)) used an int for the return value of avio_seek which returns an int64_t. Checking the return value then indicated an error even though the seek was successfull for targets in the range of 2GB-4GB, 6GB-8GB, ... This error implied that the status hasn't been reset and in particular, the old level was still considered to be in force, so that ebml_parse returned errors because the newly parsed elements were of course not contained in the previously active and still wrongly considered active master element any more. Addresses ticket #8084.

Andreas Rheinhardt committed 7 years ago

Commit c294f381 parent ddd92ba1 file · +1 −1Browse files

Unified · Split

libavformat/matroskadec.c+1−1
@@ -757,7 +757,7 @@ static int matroska_reset_status(MatroskaDemuxContext *matroska, · 756 unmodified lines
757757 uint32_t id, int64_t position)
758758 {
759759 if (position >= 0) {
760− int err = avio_seek(matroska->ctx->pb, position, SEEK_SET);
760+ int64_t err = avio_seek(matroska->ctx->pb, position, SEEK_SET);
761761 if (err < 0)
762762 return err;
763763 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t