History

avcodec/rv10: Use ff_h263_decode_init()

The RV10 and RV20 decoders use ff_h263_decode_mb() and also the H.263 DSP and VLCs. Despite not calling ff_h263_decode_frame(), it is nevertheless beneficial to call ff_h263_decode_init() to reduce code duplication.

Andreas Rheinhardt committed 2 years ago

Commit c7355521 parent 7b539ca2 files · +5 −16Browse files

Unified · Split

2 files
  1. libavcodec/h263dec.c +2 −0
  2. libavcodec/rv10.c +3 −16
libavcodec/h263dec.c+2−0
@@ -135,6 +135,8 @@ av_cold int ff_h263_decode_init(AVCodecContext *avctx) · 134 unmodified lines
135135 s->msmpeg4_version = MSMP4_WMV2;
136136 break;
137137 case AV_CODEC_ID_H263I:
138+ case AV_CODEC_ID_RV10:
139+ case AV_CODEC_ID_RV20:
138140 break;
139141 case AV_CODEC_ID_FLV1:
140142 s->h263_flv = 1;
libavcodec/rv10.c+3−16
@@ -346,7 +346,6 @@ static av_cold void rv10_init_static(void) · 345 unmodified lines
346346 rv_dc_chrom.table[(0x1FE << (DC_VLC_BITS - 9)) + i].sym = 255;
347347 rv_dc_chrom.table[(0x1FE << (DC_VLC_BITS - 9)) + i].len = 18;
348348 }
349− ff_h263_decode_init_vlc();
350349 }
351350
352351 static av_cold int rv10_decode_init(AVCodecContext *avctx)
@@ -364,16 +363,12 @@ static av_cold int rv10_decode_init(AVCodecContext *avctx) · 11 unmodified lines
364363 avctx->coded_height, 0, avctx)) < 0)
365364 return ret;
366365
367− ret = ff_mpv_decode_init(s, avctx);
366+ ret = ff_h263_decode_init(avctx);
368367 if (ret < 0)
369368 return ret;
370369
371− s->out_format = FMT_H263;
372−
373− rv->orig_width =
374− s->width = avctx->coded_width;
375− rv->orig_height =
376− s->height = avctx->coded_height;
370+ rv->orig_width = avctx->coded_width;
371+ rv->orig_height = avctx->coded_height;
377372
378373 s->h263_long_vectors = ((uint8_t *) avctx->extradata)[3] & 1;
379374 rv->sub_id = AV_RB32((uint8_t *) avctx->extradata + 4);
@@ -382,7 +377,6 @@ static av_cold int rv10_decode_init(AVCodecContext *avctx) · 2 unmodified lines
382377 minor_ver = RV_GET_MINOR_VER(rv->sub_id);
383378 micro_ver = RV_GET_MICRO_VER(rv->sub_id);
384379
385− s->low_delay = 1;
386380 switch (major_ver) {
387381 case 1:
388382 s->rv10_version = micro_ver ? 3 : 1;
@@ -405,13 +399,6 @@ static av_cold int rv10_decode_init(AVCodecContext *avctx) · 16 unmodified lines
405399 ((uint32_t *) avctx->extradata)[0]);
406400 }
407401
408− avctx->pix_fmt = AV_PIX_FMT_YUV420P;
409−
410− if ((ret = ff_mpv_common_init(s)) < 0)
411− return ret;
412−
413− ff_h263dsp_init(&s->h263dsp);
414−
415402 /* init static VLCs */
416403 ff_thread_once(&init_static_once, rv10_init_static);
417404

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t