History

lavfi: amix: check active input count before calling request_samples

fixes use of the amix filter with only 1 input

Justin Ruggles committed 14 years ago

Commit c7bd5561 parent 6163d881 file · +12 −7Browse files

Showing the changes to libavfilter (1 of 1 file). Show all

Unified · Split

libavfilter/af_amix.c+12−7
@@ -389,6 +389,10 @@ static int request_frame(AVFilterLink *outlink) · 388 unmodified lines
389389 int ret;
390390 int wanted_samples, available_samples;
391391
392+ ret = calc_active_inputs(s);
393+ if (ret < 0)
394+ return ret;
395+
392396 if (s->input_state[0] == INPUT_OFF) {
393397 ret = request_samples(ctx, 1);
394398 if (ret < 0)
@@ -419,15 +423,16 @@ static int request_frame(AVFilterLink *outlink) · 24 unmodified lines
419423 av_assert0(s->frame_list->nb_frames > 0);
420424
421425 wanted_samples = frame_list_next_frame_size(s->frame_list);
422− ret = request_samples(ctx, wanted_samples);
423− if (ret < 0)
424− return ret;
425−
426− ret = calc_active_inputs(s);
427− if (ret < 0)
428− return ret;
429426
430427 if (s->active_inputs > 1) {
428+ ret = request_samples(ctx, wanted_samples);
429+ if (ret < 0)
430+ return ret;
431+
432+ ret = calc_active_inputs(s);
433+ if (ret < 0)
434+ return ret;
435+
431436 available_samples = get_available_samples(s);
432437 if (!available_samples)
433438 return 0;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t