History

bugs found by valgrind

Originally committed as revision 4841 to svn://svn.ffmpeg.org/ffmpeg/trunk

Michael Niedermayer committed 20 years ago

Commit c8a596d1 parent 517840c3 files · +17 −16Browse files

Unified · Split

3 files
  1. libavcodec/snow.c +11 −10
  2. tests/ffmpeg.regression.ref +3 −3
  3. tests/rotozoom.regression.ref +3 −3
libavcodec/snow.c+11−10
@@ -3116,13 +3116,14 @@ static int get_block_rd(SnowContext *s, int mb_x, int mb_y, int plane_index, con · 3115 unmodified lines
31163116 BlockNode *top = y ? &s->block[index-b_stride] : &null_block;
31173117 BlockNode *tl = y && x ? &s->block[index-b_stride-1] : left;
31183118 BlockNode *tr = y && x+1<b_stride ? &s->block[index-b_stride+1] : tl;
3119− int dmx= b->mx - mid_pred(left->mx, top->mx, tr->mx);
3120− int dmy= b->my - mid_pred(left->my, top->my, tr->my);
3119+ int dmx, dmy;
31213120 // int mx_context= av_log2(2*ABS(left->mx - top->mx));
31223121 // int my_context= av_log2(2*ABS(left->my - top->my));
31233122
31243123 if(x<0 || x>=b_stride || y>=b_height)
31253124 continue;
3125+ dmx= b->mx - mid_pred(left->mx, top->mx, tr->mx);
3126+ dmy= b->my - mid_pred(left->my, top->my, tr->my);
31263127 /*
31273128 1 0 0
31283129 01X 1-2 1
@@ -3206,14 +3207,14 @@ static void iterative_me(SnowContext *s){ · 77 unmodified lines
32063207 BlockNode backup;
32073208 const int index= mb_x + mb_y * b_stride;
32083209 BlockNode *block= &s->block[index];
3209− BlockNode *tb = mb_y ? &s->block[index-b_stride ] : &null_block;
3210− BlockNode *lb = mb_x ? &s->block[index -1] : &null_block;
3211− BlockNode *rb = mb_x<b_width ? &s->block[index +1] : &null_block;
3212− BlockNode *bb = mb_y<b_height ? &s->block[index+b_stride ] : &null_block;
3213− BlockNode *tlb= mb_x && mb_y ? &s->block[index-b_stride-1] : &null_block;
3214− BlockNode *trb= mb_x<b_width && mb_y ? &s->block[index-b_stride+1] : &null_block;
3215− BlockNode *blb= mb_x && mb_y<b_height ? &s->block[index+b_stride-1] : &null_block;
3216− BlockNode *brb= mb_x<b_width && mb_y<b_height ? &s->block[index+b_stride+1] : &null_block;
3210+ BlockNode *tb = mb_y ? &s->block[index-b_stride ] : &null_block;
3211+ BlockNode *lb = mb_x ? &s->block[index -1] : &null_block;
3212+ BlockNode *rb = mb_x+1<b_width ? &s->block[index +1] : &null_block;
3213+ BlockNode *bb = mb_y+1<b_height ? &s->block[index+b_stride ] : &null_block;
3214+ BlockNode *tlb= mb_x && mb_y ? &s->block[index-b_stride-1] : &null_block;
3215+ BlockNode *trb= mb_x+1<b_width && mb_y ? &s->block[index-b_stride+1] : &null_block;
3216+ BlockNode *blb= mb_x && mb_y+1<b_height ? &s->block[index+b_stride-1] : &null_block;
3217+ BlockNode *brb= mb_x+1<b_width && mb_y+1<b_height ? &s->block[index+b_stride+1] : &null_block;
32173218 const int b_w= (MB_SIZE >> s->block_max_depth);
32183219 uint8_t obmc_edged[b_w*2][b_w*2];
32193220
tests/ffmpeg.regression.ref+3−3
@@ -119,9 +119,9 @@ a7ef4746f27be309138c188e327d3ebe *./data/a-ffv1.avi · 118 unmodified lines
119119 2653642 ./data/a-ffv1.avi
120120 799d3db687f6cdd7a837ec156efc171f *./data/out.yuv
121121 stddev: 0.00 PSNR:99.99 bytes:7602176
122−14fa515bf25a47fc2ad3d18b726e8e31 *./data/a-snow.avi
123−1197138 ./data/a-snow.avi
124−e7c746171b092266b0cf55bb5de2a40a *./data/out.yuv
122+97c7066617d9e6c86a43a2736b3e9f16 *./data/a-snow.avi
123+1190760 ./data/a-snow.avi
124+7e4d9c61252ff22b1a0d4e892cc1d957 *./data/out.yuv
125125 stddev: 2.89 PSNR:38.87 bytes:7602176
126126 11fd61ee7e67ef7a7b2a3df973691305 *./data/a-snow53.avi
127127 3533710 ./data/a-snow53.avi
tests/rotozoom.regression.ref+3−3
@@ -119,9 +119,9 @@ d0831a8339491fd680b650f05262e5d9 *./data/a-ffv1.avi · 118 unmodified lines
119119 3524768 ./data/a-ffv1.avi
120120 dde5895817ad9d219f79a52d0bdfb001 *./data/out.yuv
121121 stddev: 0.00 PSNR:99.99 bytes:7602176
122−b926518ac399c7af0f218a7115315b4f *./data/a-snow.avi
123−286800 ./data/a-snow.avi
124−6c59db71d950610f854d05e2cef18609 *./data/out.yuv
122+7345af7da71320bf87d3c950252b4341 *./data/a-snow.avi
123+286798 ./data/a-snow.avi
124+cc5ef1eda02091fbf9a85887bad47bc4 *./data/out.yuv
125125 stddev: 2.32 PSNR:40.80 bytes:7602176
126126 3f20642bb789dfb75ae3e8c03f9b425c *./data/a-snow53.avi
127127 2725570 ./data/a-snow53.avi

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t