History

avfilter/vf_overlay: Avoid converting stride to uint16_t and back

Just keep the pointers for the beginning of a line uint8_t* and use uint16_t* to do the actual processing.

Andreas Rheinhardt committed 1 year ago

Commit ca51a0f1 parent eeb82a41 file · +19 −23Browse files

Showing the changes to libavfilter (1 of 1 file). Show all

Unified · Split

libavfilter/vf_overlay.c+19−23
@@ -467,7 +467,6 @@ static av_always_inline void blend_plane_##depth##_##nbits##bits(AVFilterContext · 466 unmodified lines
467467 int dst_hp = AV_CEIL_RSHIFT(dst_h, vsub); \
468468 int yp = y>>vsub; \
469469 int xp = x>>hsub; \
470− uint##depth##_t *s, *sp, *d, *dp, *dap, *a, *ap; \
471470 int jmax, j, k, kmax; \
472471 int slice_start, slice_end; \
473472 const uint##depth##_t max = (1 << nbits) - 1; \
@@ -481,20 +480,19 @@ static av_always_inline void blend_plane_##depth##_##nbits##bits(AVFilterContext · 7 unmodified lines
481480 slice_start = j + (jmax * jobnr) / nb_jobs; \
482481 slice_end = j + (jmax * (jobnr+1)) / nb_jobs; \
483482 \
484− sp = (uint##depth##_t *)(src->data[i] + (slice_start) * src->linesize[i]); \
485− dp = (uint##depth##_t *)(dst->data[dst_plane] \
483+ const uint8_t *sp = src->data[i] + (slice_start) * src->linesize[i]; \
484+ uint8_t *dp = dst->data[dst_plane] \
486485 + (yp + slice_start) * dst->linesize[dst_plane] \
487− + dst_offset); \
488− ap = (uint##depth##_t *)(src->data[3] + (slice_start << vsub) * src->linesize[3]); \
489− if (main_has_alpha) \
490− dap = (uint##depth##_t *)(dst->data[3] + ((yp + slice_start) << vsub) * dst->linesize[3]); \
486+ + dst_offset; \
487+ const uint8_t *ap = src->data[3] + (slice_start << vsub) * src->linesize[3]; \
488+ const uint8_t *dap = main_has_alpha ? dst->data[3] + ((yp + slice_start) << vsub) * dst->linesize[3] : NULL; \
491489 \
492490 for (j = slice_start; j < slice_end; j++) { \
493491 k = FFMAX(-xp, 0); \
494− d = dp + (xp+k) * dst_step; \
495− s = sp + k; \
496− a = ap + (k<<hsub); \
497− uint##depth##_t *da = main_has_alpha ? dap + ((xp+k) << hsub) : NULL; \
492+ const uint##depth##_t *s = (const uint##depth##_t *)sp + k; \
493+ const uint##depth##_t *a = (const uint##depth##_t *)ap + (k<<hsub); \
494+ const uint##depth##_t *da = main_has_alpha ? (uint##depth##_t *)dap + ((xp + k) << hsub) : NULL; \
495+ uint##depth##_t *d = (uint##depth##_t *)dp + (xp + k) * dst_step; \
498496 kmax = FFMIN(-xp + dst_wp, src_wp); \
499497 \
500498 if (nbits == 8 && ((vsub && j+1 < src_hp) || !vsub) && octx->blend_row[i]) { \
@@ -566,11 +564,11 @@ static av_always_inline void blend_plane_##depth##_##nbits##bits(AVFilterContext · 65 unmodified lines
566564 da += 1 << hsub; \
567565 a += 1 << hsub; \
568566 } \
569− dp += dst->linesize[dst_plane] / bytes; \
570− sp += src->linesize[i] / bytes; \
571− ap += (1 << vsub) * src->linesize[3] / bytes; \
567+ dp += dst->linesize[dst_plane]; \
568+ sp += src->linesize[i]; \
569+ ap += (1 << vsub) * src->linesize[3]; \
572570 if (main_has_alpha) \
573− dap += (1 << vsub) * dst->linesize[3] / bytes; \
571+ dap += (1 << vsub) * dst->linesize[3]; \
574572 } \
575573 }
576574 DEFINE_BLEND_PLANE(8, 8)
@@ -584,11 +582,9 @@ static inline void alpha_composite_##depth##_##nbits##bits(const AVFrame *src, c · 7 unmodified lines
584582 int jobnr, int nb_jobs) \
585583 { \
586584 uint##depth##_t alpha; /* the amount of overlay to blend on to main */ \
587− uint##depth##_t *s, *sa, *d, *da; \
588585 int i, imax, j, jmax; \
589586 int slice_start, slice_end; \
590587 const uint##depth##_t max = (1 << nbits) - 1; \
591− int bytes = depth / 8; \
592588 \
593589 imax = FFMIN3(-y + dst_h, FFMIN(src_h, dst_h), y + src_h); \
594590 i = FFMAX(-y, 0); \
@@ -596,13 +592,13 @@ static inline void alpha_composite_##depth##_##nbits##bits(const AVFrame *src, c · 1 unmodified line
596592 slice_start = i + (imax * jobnr) / nb_jobs; \
597593 slice_end = i + ((imax * (jobnr+1)) / nb_jobs); \
598594 \
599− sa = (uint##depth##_t *)(src->data[3] + (slice_start) * src->linesize[3]); \
600− da = (uint##depth##_t *)(dst->data[3] + (y + slice_start) * dst->linesize[3]); \
595+ const uint8_t *sa = src->data[3] + (slice_start) * src->linesize[3]; \
596+ uint8_t *da = dst->data[3] + (y + slice_start) * dst->linesize[3]; \
601597 \
602598 for (i = slice_start; i < slice_end; i++) { \
603599 j = FFMAX(-x, 0); \
604− s = sa + j; \
605− d = da + x+j; \
600+ const uint##depth##_t *s = (const uint##depth##_t *)sa + j; \
601+ uint##depth##_t *d = (uint##depth##_t *)da + x+j; \
606602 \
607603 for (jmax = FFMIN(-x + dst_w, src_w); j < jmax; j++) { \
608604 alpha = *s; \
@@ -622,8 +618,8 @@ static inline void alpha_composite_##depth##_##nbits##bits(const AVFrame *src, c · 13 unmodified lines
622618 d += 1; \
623619 s += 1; \
624620 } \
625− da += dst->linesize[3] / bytes; \
626− sa += src->linesize[3] / bytes; \
621+ da += dst->linesize[3]; \
622+ sa += src->linesize[3]; \
627623 } \
628624 }
629625 DEFINE_ALPHA_COMPOSITE(8, 8)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t