History

Do not leave positive values undefined when negative are defined as error

Define positive return values as non errors and leave further meaning undefined This allows future extensions to use these values

Michael Niedermayer committed 13 years ago

Commit d5ec8ba1 parent a63886118 files · +30 −30Browse files

Showing the changes to libavfilter/graphparser.c (1 of 18 files). Show all

Unified · Split

libavfilter/graphparser.c+2−2
@@ -89,7 +89,7 @@ static char *parse_link_name(const char **buf, void *log_ctx) · 88 unmodified lines
89 * @param filt_name the name of the filter to create89 * @param filt_name the name of the filter to create
90 * @param args the arguments provided to the filter during its initialization90 * @param args the arguments provided to the filter during its initialization
91 * @param log_ctx the log context to use91 * @param log_ctx the log context to use
92 * @return 0 in case of success, a negative AVERROR code otherwise92 * @return >= 0 in case of success, a negative AVERROR code otherwise
93 */93 */
94static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int index,94static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int index,
95 const char *filt_name, const char *args, void *log_ctx)95 const char *filt_name, const char *args, void *log_ctx)
@@ -152,7 +152,7 @@ static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int ind · 56 unmodified lines
152 * @param index an index which is assigned to the created filter152 * @param index an index which is assigned to the created filter
153 * instance, and which is supposed to be unique for each filter153 * instance, and which is supposed to be unique for each filter
154 * instance added to the filtergraph154 * instance added to the filtergraph
155 * @return 0 in case of success, a negative AVERROR code otherwise155 * @return >= 0 in case of success, a negative AVERROR code otherwise
156 */156 */
157static int parse_filter(AVFilterContext **filt_ctx, const char **buf, AVFilterGraph *graph,157static int parse_filter(AVFilterContext **filt_ctx, const char **buf, AVFilterGraph *graph,
158 int index, void *log_ctx)158 int index, void *log_ctx)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t