History

avutil/hwcontext_vulkan: Query the correct format

In the call to vkGetPhysicalDeviceImageFormatProperties2(), we were previously requesting the properties of the first fallback format (e.g. VK_FORMAT_R8_UNORM for VK_FORMAT_G8_B8R8_2PLANE_420_UNORM) instead of the actual format in use. We don’t do anything with it afterwards, but there is no reason to keep querying the wrong format.

Link Mauve committed 1 year ago

Commit d5f4a551 parent 0f751d31 file · +1 −1Browse files

Unified · Split

libavutil/hwcontext_vulkan.c+1−1
@@ -2590,7 +2590,7 @@ static void try_export_flags(AVHWFramesContext *hwfc, · 2589 unmodified lines
2590 VkPhysicalDeviceImageFormatInfo2 pinfo = {2590 VkPhysicalDeviceImageFormatInfo2 pinfo = {
2591 .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_FORMAT_INFO_2,2591 .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_FORMAT_INFO_2,
2592 .pNext = !exp ? NULL : &enext,2592 .pNext = !exp ? NULL : &enext,
2593 .format = av_vkfmt_from_pixfmt(hwfc->sw_format)[0],2593 .format = vk_find_format_entry(hwfc->sw_format)->vkf,
2594 .type = VK_IMAGE_TYPE_2D,2594 .type = VK_IMAGE_TYPE_2D,
2595 .tiling = hwctx->tiling,2595 .tiling = hwctx->tiling,
2596 .usage = hwctx->usage,2596 .usage = hwctx->usage,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t