History

lavc/ffv1dec: declare loop variables in the loop where possible

Anton Khirnov committed 2 years ago

Commit d776fa41 parent 8e19c241 file · +22 −23Browse files

Showing the changes to libavcodec (1 of 1 file). Show all

Unified · Split

libavcodec/ffv1dec.c+22−23
@@ -46,7 +46,7 @@ static inline av_flatten int get_symbol_inline(RangeCoder *c, uint8_t *state, · 45 unmodified lines
4646 if (get_rac(c, state + 0))
4747 return 0;
4848 else {
49− int i, e;
49+ int e;
5050 unsigned a;
5151 e = 0;
5252 while (get_rac(c, state + 1 + FFMIN(e, 9))) { // 1..10
@@ -56,7 +56,7 @@ static inline av_flatten int get_symbol_inline(RangeCoder *c, uint8_t *state, · 3 unmodified lines
5656 }
5757
5858 a = 1;
59− for (i = e - 1; i >= 0; i--)
59+ for (int i = e - 1; i >= 0; i--)
6060 a += a + get_rac(c, state + 22 + FFMIN(i, 9)); // 22..31
6161
6262 e = -(is_signed && get_rac(c, state + 11 + FFMIN(e, 10))); // 11..21
@@ -167,7 +167,7 @@ static int decode_slice_header(const FFV1Context *f, FFV1Context *fs) · 104 unmodified lines
167167 {
168168 RangeCoder *c = &fs->c;
169169 uint8_t state[CONTEXT_SIZE];
170− unsigned ps, i, context_count;
170+ unsigned ps, context_count;
171171 int sx, sy, sw, sh;
172172
173173 memset(state, 128, sizeof(state));
@@ -197,7 +197,7 @@ static int decode_slice_header(const FFV1Context *f, FFV1Context *fs) · 23 unmodified lines
197197 if (fs->ac == AC_GOLOMB_RICE && fs->slice_width >= (1<<23))
198198 return AVERROR_INVALIDDATA;
199199
200− for (i = 0; i < f->plane_count; i++) {
200+ for (unsigned i = 0; i < f->plane_count; i++) {
201201 PlaneContext * const p = &fs->plane[i];
202202 int idx = get_symbol(c, state, 0);
203203 if (idx >= (unsigned)f->quant_table_count) {
@@ -259,7 +259,7 @@ static int decode_slice(AVCodecContext *c, void *arg) · 55 unmodified lines
259259 int width, height, x, y, ret;
260260 const int ps = av_pix_fmt_desc_get(c->pix_fmt)->comp[0].step;
261261 AVFrame * const p = f->cur;
262− int i, si;
262+ int si;
263263
264264 for( si=0; fs != f->slice_context[si]; si ++)
265265 ;
@@ -276,7 +276,7 @@ static int decode_slice(AVCodecContext *c, void *arg) · 10 unmodified lines
276276 if (!(p->flags & AV_FRAME_FLAG_KEY))
277277 fsdst->slice_damaged |= fssrc->slice_damaged;
278278
279− for (i = 0; i < f->plane_count; i++) {
279+ for (int i = 0; i < f->plane_count; i++) {
280280 PlaneContext *psrc = &fssrc->plane[i];
281281 PlaneContext *pdst = &fsdst->plane[i];
282282
@@ -424,7 +424,7 @@ static int read_extra_header(FFV1Context *f) · 141 unmodified lines
424424 {
425425 RangeCoder *const c = &f->c;
426426 uint8_t state[CONTEXT_SIZE];
427− int i, j, k, ret;
427+ int ret;
428428 uint8_t state2[32][CONTEXT_SIZE];
429429 unsigned crc = 0;
430430
@@ -453,7 +453,7 @@ static int read_extra_header(FFV1Context *f) · 22 unmodified lines
453453 f->ac = get_symbol(c, state, 0);
454454
455455 if (f->ac == AC_RANGE_CUSTOM_TAB) {
456− for (i = 1; i < 256; i++)
456+ for (int i = 1; i < 256; i++)
457457 f->state_transition[i] = get_symbol(c, state, 1) + c->one_state[i];
458458 }
459459
@@ -492,7 +492,7 @@ static int read_extra_header(FFV1Context *f) · 32 unmodified lines
492492 return AVERROR_INVALIDDATA;
493493 }
494494
495− for (i = 0; i < f->quant_table_count; i++) {
495+ for (int i = 0; i < f->quant_table_count; i++) {
496496 f->context_count[i] = read_quant_tables(c, f->quant_tables[i]);
497497 if (f->context_count[i] < 0) {
498498 av_log(f->avctx, AV_LOG_ERROR, "read_quant_table error\n");
@@ -502,10 +502,10 @@ static int read_extra_header(FFV1Context *f) · 3 unmodified lines
502502 if ((ret = ff_ffv1_allocate_initial_states(f)) < 0)
503503 return ret;
504504
505− for (i = 0; i < f->quant_table_count; i++)
505+ for (int i = 0; i < f->quant_table_count; i++)
506506 if (get_rac(c, state)) {
507− for (j = 0; j < f->context_count[i]; j++)
508− for (k = 0; k < CONTEXT_SIZE; k++) {
507+ for (int j = 0; j < f->context_count[i]; j++)
508+ for (int k = 0; k < CONTEXT_SIZE; k++) {
509509 int pred = j ? f->initial_states[i][j - 1][k] : 128;
510510 f->initial_states[i][j][k] =
511511 (pred + get_symbol(c, state2[k], 1)) & 0xFF;
@@ -550,7 +550,7 @@ static int read_extra_header(FFV1Context *f) · 38 unmodified lines
550550 static int read_header(FFV1Context *f)
551551 {
552552 uint8_t state[CONTEXT_SIZE];
553− int i, j, context_count = -1; //-1 to avoid warning
553+ int context_count = -1; //-1 to avoid warning
554554 RangeCoder *const c = &f->slice_context[0]->c;
555555
556556 memset(state, 128, sizeof(state));
@@ -566,7 +566,7 @@ static int read_header(FFV1Context *f) · 9 unmodified lines
566566 f->ac = get_symbol(c, state, 0);
567567
568568 if (f->ac == AC_RANGE_CUSTOM_TAB) {
569− for (i = 1; i < 256; i++) {
569+ for (int i = 1; i < 256; i++) {
570570 int st = get_symbol(c, state, 1) + c->one_state[i];
571571 if (st < 1 || st > 255) {
572572 av_log(f->avctx, AV_LOG_ERROR, "invalid state transition %d\n", st);
@@ -790,7 +790,7 @@ static int read_header(FFV1Context *f) · 217 unmodified lines
790790 return AVERROR_INVALIDDATA;
791791 }
792792
793− for (j = 0; j < f->slice_count; j++) {
793+ for (int j = 0; j < f->slice_count; j++) {
794794 FFV1Context *fs = f->slice_context[j];
795795 fs->ac = f->ac;
796796 fs->packed_at_lsb = f->packed_at_lsb;
@@ -819,7 +819,7 @@ static int read_header(FFV1Context *f) · 22 unmodified lines
819819 && (unsigned)fs->slice_y + (uint64_t)fs->slice_height <= f->height);
820820 }
821821
822− for (i = 0; i < f->plane_count; i++) {
822+ for (int i = 0; i < f->plane_count; i++) {
823823 PlaneContext *const p = &fs->plane[i];
824824
825825 if (f->version == 2) {
@@ -874,7 +874,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *rframe, · 48 unmodified lines
874874 int buf_size = avpkt->size;
875875 FFV1Context *f = avctx->priv_data;
876876 RangeCoder *const c = &f->slice_context[0]->c;
877− int i, ret, key_frame;
877+ int ret, key_frame;
878878 uint8_t keystate = 128;
879879 uint8_t *buf_p;
880880 AVFrame *p;
@@ -908,6 +908,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *rframe, · 27 unmodified lines
908908 } else {
909909 int w = avctx->width;
910910 int s = 1 + w / (1<<23);
911+ int i;
911912
912913 w /= s;
913914
@@ -941,7 +942,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *rframe, · 27 unmodified lines
941942 ff_thread_finish_setup(avctx);
942943
943944 buf_p = buf + buf_size;
944− for (i = f->slice_count - 1; i >= 0; i--) {
945+ for (int i = f->slice_count - 1; i >= 0; i--) {
945946 FFV1Context *fs = f->slice_context[i];
946947 int trailer = 3 + 5*!!f->ec;
947948 int v;
@@ -991,15 +992,14 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *rframe, · 43 unmodified lines
991992 f->slice_count,
992993 sizeof(void*));
993994
994− for (i = f->slice_count - 1; i >= 0; i--) {
995+ for (int i = f->slice_count - 1; i >= 0; i--) {
995996 FFV1Context *fs = f->slice_context[i];
996− int j;
997997 if (fs->slice_damaged && f->last_picture.f) {
998998 const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(avctx->pix_fmt);
999999 const uint8_t *src[4];
10001000 uint8_t *dst[4];
10011001 ff_progress_frame_await(&f->last_picture, INT_MAX);
1002− for (j = 0; j < desc->nb_components; j++) {
1002+ for (int j = 0; j < desc->nb_components; j++) {
10031003 int pixshift = desc->comp[j].depth > 8;
10041004 int sh = (j == 1 || j == 2) ? f->chroma_h_shift : 0;
10051005 int sv = (j == 1 || j == 2) ? f->chroma_v_shift : 0;
@@ -1064,7 +1064,6 @@ static int update_thread_context(AVCodecContext *dst, const AVCodecContext *src) · 58 unmodified lines
10641064 {
10651065 FFV1Context *fsrc = src->priv_data;
10661066 FFV1Context *fdst = dst->priv_data;
1067− int i;
10681067
10691068 if (dst == src)
10701069 return 0;
@@ -1075,7 +1074,7 @@ static int update_thread_context(AVCodecContext *dst, const AVCodecContext *src) · 4 unmodified lines
10751074 sizeof(fdst->state_transition));
10761075 memcpy(fdst->quant_table, fsrc->quant_table, sizeof(fsrc->quant_table));
10771076
1078− for (i = 0; i < fdst->num_h_slices * fdst->num_v_slices; i++) {
1077+ for (int i = 0; i < fdst->num_h_slices * fdst->num_v_slices; i++) {
10791078 FFV1Context *fssrc = fsrc->slice_context[i];
10801079 FFV1Context *fsdst = fdst->slice_context[i];
10811080 copy_fields(fsdst, fssrc, fsrc);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t