When finding a video mode based on frame size and frame rate, use AVRational methods instead of simple comparison. Add debug information.
Showing the changes to libavdevice/decklink_common.cpp (1 of 1 file). Show all
Unified · Split
| @@ -143,6 +143,9 @@ int ff_decklink_set_format(AVFormatContext *avctx, · 142 unmodified lines | ||
| 143 | 143 | int i = 1; |
| 144 | 144 | HRESULT res; |
| 145 | 145 | |
| 146 | + av_log(avctx, AV_LOG_DEBUG, "Trying to find mode for frame size %dx%d, frame timing %d/%d, direction %d, mode number %d\n", | |
| 147 | + width, height, tb_num, tb_den, direction, num); | |
| 148 | + | |
| 146 | 149 | if (ctx->duplex_mode) { |
| 147 | 150 | DECKLINK_BOOL duplex_supported = false; |
| 148 | 151 | |
| @@ -178,11 +181,7 @@ int ff_decklink_set_format(AVFormatContext *avctx, · 29 unmodified lines | ||
| 178 | 181 | return AVERROR(EIO); |
| 179 | 182 | } |
| 180 | 183 | |
| 181 | − | |
| 182 | − if (tb_num == 1) { | |
| 183 | − tb_num *= 1000; | |
| 184 | − tb_den *= 1000; | |
| 185 | − } | |
| 184 | + AVRational target_tb = av_make_q(tb_num, tb_den); | |
| 186 | 185 | ctx->bmd_mode = bmdModeUnknown; |
| 187 | 186 | while ((ctx->bmd_mode == bmdModeUnknown) && itermode->Next(&mode) == S_OK) { |
| 188 | 187 | BMDTimeValue bmd_tb_num, bmd_tb_den; |
| @@ -190,9 +189,10 @@ int ff_decklink_set_format(AVFormatContext *avctx, · 1 unmodified line | ||
| 190 | 189 | int bmd_height = mode->GetHeight(); |
| 191 | 190 | |
| 192 | 191 | mode->GetFrameRate(&bmd_tb_num, &bmd_tb_den); |
| 192 | + AVRational mode_tb = av_make_q(bmd_tb_num, bmd_tb_den); | |
| 193 | 193 | |
| 194 | 194 | if ((bmd_width == width && bmd_height == height && |
| 195 | − bmd_tb_num == tb_num && bmd_tb_den == tb_den) || i == num) { | |
| 195 | + !av_cmp_q(mode_tb, target_tb)) || i == num) { | |
| 196 | 196 | ctx->bmd_mode = mode->GetDisplayMode(); |
| 197 | 197 | ctx->bmd_width = bmd_width; |
| 198 | 198 | ctx->bmd_height = bmd_height; |
| @@ -200,7 +200,7 @@ int ff_decklink_set_format(AVFormatContext *avctx, · 1 unmodified line | ||
| 200 | 200 | ctx->bmd_tb_num = bmd_tb_num; |
| 201 | 201 | ctx->bmd_field_dominance = mode->GetFieldDominance(); |
| 202 | 202 | av_log(avctx, AV_LOG_INFO, "Found Decklink mode %d x %d with rate %.2f%s\n", |
| 203 | − bmd_width, bmd_height, (float)bmd_tb_den/(float)bmd_tb_num, | |
| 203 | + bmd_width, bmd_height, 1/av_q2d(mode_tb), | |
| 204 | 204 | (ctx->bmd_field_dominance==bmdLowerFieldFirst || ctx->bmd_field_dominance==bmdUpperFieldFirst)?"(i)":""); |
| 205 | 205 | } |
| 206 | 206 | |