The TTA muxer writes a seektable in a dynamic buffer as it receives packets and when writing the trailer, closes the dynamic buffer using avio_close_dyn_buf(), writes the seektable and frees the buffer. But the TTA muxer already has a deinit function which unconditionally calls ffio_free_dyn_buf() on the dynamic buffer, so switching to avio_get_dyn_buf() means that one can remove the code to free the buffer; furthermore, it also might save an allocation if the seektable is so small that it fits into the dynamic buffer's write buffer or if adding the padding that avio_close_dyn_buf() adds necessitated reallocating of the underlying buffer.
Unified · Split
| @@ -145,10 +145,8 @@ static int tta_write_trailer(AVFormatContext *s) · 144 unmodified lines | ||
| 145 | 145 | /* Write Seek table */ |
| 146 | 146 | crc = ffio_get_checksum(tta->seek_table) ^ UINT32_MAX; |
| 147 | 147 | avio_wl32(tta->seek_table, crc); |
| 148 | − size = avio_close_dyn_buf(tta->seek_table, &ptr); | |
| 148 | + size = avio_get_dyn_buf(tta->seek_table, &ptr); | |
| 149 | 149 | avio_write(s->pb, ptr, size); |
| 150 | − tta->seek_table = NULL; | |
| 151 | − av_free(ptr); | |
| 152 | 150 | |
| 153 | 151 | /* Write audio data */ |
| 154 | 152 | tta_queue_flush(s); |