History

id3v2: prefer TDRC for date over TDRL.

TDRL is what we used as a replacement of TYER, and, according to http://id3.org/id3v2.4.0-changes : TYER - Year This frame is replaced by the TDRC frame, 'Recording time' [F:4.2.5]. So change TDRL usages to TDRC. Fixes ticket #3694

Benoit Fouet committed 12 years ago

Commit dc351e11 parent 3dae05f2 files · +2 −2Browse files

Unified · Split

2 files
  1. libavformat/id3v2.c +1 −1
  2. libavformat/mp3enc.c +1 −1
libavformat/id3v2.c+1−1
@@ -60,8 +60,8 @@ const AVMetadataConv ff_id3v2_34_metadata_conv[] = { · 59 unmodified lines
60 60
61const AVMetadataConv ff_id3v2_4_metadata_conv[] = {61const AVMetadataConv ff_id3v2_4_metadata_conv[] = {
62 { "TCMP", "compilation" },62 { "TCMP", "compilation" },
63 { "TDRL", "date" },
64 { "TDRC", "date" },63 { "TDRC", "date" },
64 { "TDRL", "date" },
65 { "TDEN", "creation_time" },65 { "TDEN", "creation_time" },
66 { "TSOA", "album-sort" },66 { "TSOA", "album-sort" },
67 { "TSOP", "artist-sort" },67 { "TSOP", "artist-sort" },
libavformat/mp3enc.c+1−1
@@ -58,7 +58,7 @@ static int id3v1_create_tag(AVFormatContext *s, uint8_t *buf) · 57 unmodified lines
58 count += id3v1_set_string(s, "TIT2", buf + 3, 30 + 1); //title58 count += id3v1_set_string(s, "TIT2", buf + 3, 30 + 1); //title
59 count += id3v1_set_string(s, "TPE1", buf + 33, 30 + 1); //author|artist59 count += id3v1_set_string(s, "TPE1", buf + 33, 30 + 1); //author|artist
60 count += id3v1_set_string(s, "TALB", buf + 63, 30 + 1); //album60 count += id3v1_set_string(s, "TALB", buf + 63, 30 + 1); //album
61 count += id3v1_set_string(s, "TDRL", buf + 93, 4 + 1); //date61 count += id3v1_set_string(s, "TDRC", buf + 93, 4 + 1); //date
62 count += id3v1_set_string(s, "comment", buf + 97, 30 + 1);62 count += id3v1_set_string(s, "comment", buf + 97, 30 + 1);
63 if ((tag = av_dict_get(s->metadata, "TRCK", NULL, 0))) { //track63 if ((tag = av_dict_get(s->metadata, "TRCK", NULL, 0))) { //track
64 buf[125] = 0;64 buf[125] = 0;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t