avfilter/vf_signature: Fix integer overflow in filter_frame()

Fixes: CID1403233 The second of the 2 changes may be unneeded but will help coverity

Michael Niedermayer committed 4 years ago

Commit dd604061 parent 73c0fd21 file · +2 −2Browse files

Unified · Split

libavfilter/vf_signature.c+2−2

@@ -219,7 +219,7 @@ static int filter_frame(AVFilterLink inlink, AVFrame picref) · 218 unmodified lines
219	219	dw1 = inlink->w / 32;
220	220	if (inlink->w % 32)
221	221	dw2 = dw1 + 1;
222		− denom = (sc->divide) ? dh1 * dh2 * dw1 * dw2 : 1;
	222	+ denom = (sc->divide) ? dh1 * (int64_t)dh2 * dw1 * dw2 : 1;
223	223
224	224	for (i = 0; i < 32; i++) {
225	225	rowcount = 0;
@@ -245,7 +245,7 @@ static int filter_frame(AVFilterLink inlink, AVFrame picref) · 19 unmodified lines
245	245	}
246	246	}
247	247
248		− denom = (sc->divide) ? 1 : dh1 * dh2 * dw1 * dw2;
	248	+ denom = (sc->divide) ? 1 : dh1 * (int64_t)dh2 * dw1 * dw2;
249	249
250	250	for (i = 0; i < ELEMENT_COUNT; i++) {
251	251	const ElemCat* elemcat = elements[i];