History

swresample/x86/resample: Remove obsolete MMXEXT functions

x64 always has MMX, MMXEXT, SSE and SSE2 and this means that some functions for MMX, MMXEXT, SSE and 3dnow are always overridden by other functions (unless one e.g. explicitly disables SSE2). So given that the only systems which benefit from the MMXEXT resamplers (which are overridden by SSE2) are truely ancient 32bit x86s they are removed.

Andreas Rheinhardt committed 4 years ago

Commit dd61d641 parent 4e51e482 files · +0 −10Browse files

Unified · Split

2 files
  1. libswresample/x86/resample.asm +0 −5
  2. libswresample/x86/resample_init.c +0 −5
libswresample/x86/resample.asm+0−5
@@ -594,11 +594,6 @@ INIT_XMM fma4 · 593 unmodified lines
594594 RESAMPLE_FNS float, 4, 2, s, pf_1
595595 %endif
596596
597−%if ARCH_X86_32
598−INIT_MMX mmxext
599−RESAMPLE_FNS int16, 2, 1
600−%endif
601−
602597 INIT_XMM sse2
603598 RESAMPLE_FNS int16, 2, 1
604599 %if HAVE_XOP_EXTERNAL
libswresample/x86/resample_init.c+0−5
@@ -35,7 +35,6 @@ int ff_resample_common_##type##_##opt(ResampleContext *c, void *dst, \ · 34 unmodified lines
3535 int ff_resample_linear_##type##_##opt(ResampleContext *c, void *dst, \
3636 const void *src, int sz, int upd)
3737
38−RESAMPLE_FUNCS(int16, mmxext);
3938 RESAMPLE_FUNCS(int16, sse2);
4039 RESAMPLE_FUNCS(int16, xop);
4140 RESAMPLE_FUNCS(float, sse);
@@ -52,10 +51,6 @@ av_cold void swri_resample_dsp_x86_init(ResampleContext *c) · 10 unmodified lines
5251
5352 switch(c->format){
5453 case AV_SAMPLE_FMT_S16P:
55− if (ARCH_X86_32 && EXTERNAL_MMXEXT(mm_flags)) {
56− c->dsp.resample_linear = ff_resample_linear_int16_mmxext;
57− c->dsp.resample_common = ff_resample_common_int16_mmxext;
58− }
5954 if (EXTERNAL_SSE2(mm_flags)) {
6055 c->dsp.resample_linear = ff_resample_linear_int16_sse2;
6156 c->dsp.resample_common = ff_resample_common_int16_sse2;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t